Closed Bug 1594750 Opened 2 years ago Closed 2 years ago

Distinguish workers in the TargetList

Categories

(DevTools :: Framework, task, P2)

task

Tracking

(Fission Milestone:M6, firefox78 fixed)

RESOLVED FIXED
Firefox 78
Fission Milestone M6
Tracking Status
firefox78 --- fixed

People

(Reporter: ochameau, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-m2-mvp)

Attachments

(1 file)

In bug 1471754, the original implementation of TargetList, TargetList.TYPES.WORKER could potentially return any type of workers: DEDICATED / SHARED or SERVICE.

This is propably a mistake as SERVICE require some more special treatment and will be hard to support in the current state?

I would suggest to make it so that TargetList.TYPES.WORKER only returns DEDICATED workers, so the regular document workers.

And introduce new types for the other two type of workers:

  • TargetList.TYPES.SHARED_WORKER
  • TargetList.TYPES.SERVICE_WORKER

Then it would be easier to handle the complex logic that is required for the Service Workers. i.e. this logic: https://searchfox.org/mozilla-central/source/devtools/shared/fronts/root.js#121-187

Blocks: 1594754

I imagine it would be easier to first support only TYPES.WORKER and TYPES.SHARED_WORKER in this bug.
And then followup in bug 1594754 to support TYPES.SERVICE_WORKER.

And, it might be great to first start by having tests for regular workers (bug 1594739).

Depends on: 1594739
Priority: -- → P2
Whiteboard: dt-fission-m2-mvp

Tracking for Fission Nightly (M6)

Fission Milestone: --- → M6
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Type: enhancement → task
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/419850fb6f75
Distinguish workers in the TargetList. r=jdescottes.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
You need to log in before you can comment on or make changes to this bug.