1594750 - Distinguish workers in the TargetList

Status: RESOLVED FIXED

(DevTools :: Framework, task, P2)

Description

[Alexandre Poirot [:ochameau]]

In bug 1471754, the original implementation of TargetList, TargetList.TYPES.WORKER could potentially return any type of workers: DEDICATED / SHARED or SERVICE.

This is propably a mistake as SERVICE require some more special treatment and will be hard to support in the current state?

I would suggest to make it so that TargetList.TYPES.WORKER only returns DEDICATED workers, so the regular document workers.

And introduce new types for the other two type of workers:

• TargetList.TYPES.SHARED_WORKER
• TargetList.TYPES.SERVICE_WORKER

Then it would be easier to handle the complex logic that is required for the Service Workers. i.e. this logic: https://searchfox.org/mozilla-central/source/devtools/shared/fronts/root.js#121-187

Comment 1

[Alexandre Poirot [:ochameau]]

I imagine it would be easier to first support only TYPES.WORKER and TYPES.SHARED_WORKER in this bug.
And then followup in bug 1594754 to support TYPES.SERVICE_WORKER.

Comment 2

[Alexandre Poirot [:ochameau]]

And, it might be great to first start by having tests for regular workers (bug 1594739).

Comment 3

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly (M6)

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1594750 - Distinguish workers in the TargetList. r=jdescottes.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/419850fb6f75
Distinguish workers in the TargetList. r=jdescottes.

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/419850fb6f75