1594827 - Firefox fails to build with Rust 1.39.0 (Rust error: E0204, E0119)

Status: RESOLVED DUPLICATE of bug 1583471

(Core :: CSS Parsing and Computation, defect)

Description

[dylan.araps]

Attachment: Build log excerpt.

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Steps to reproduce:

• Install Rust 1.39.0.
• Build Firefox using mach build.
• Large number of errors (E0204, E0119) in multiple Rust files.

Actual results:

The build failed due to Rust language errors.

Expected results:

The build should succeed.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Which Firefox version are you building? This is an already-fixed bindgen bug that a change in the Rust standard library exposed, see:

• https://github.com/rust-lang/rust-bindgen/pull/1627
• https://github.com/rust-lang/rust/issues/64710

The bug updating Bindgen landed on 71, bug 1583471.

Comment 3

[dylan.araps]

I'm building version 70.0.1. If this is fixed in 71.0.0, feel free to close this.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Yeah, this is fixed in 71, I use 0.39 locally on trunk.

Thanks for reporting!

Comment 5

[tt_1]

ehm, you might want to fix this properly? Right now there's no cve against rust, but something as CVE-2019-12083 might happen again. I agree that the informations provided aren't awfully helpfull, I can provide a build log with the errors to ease debugging this. Just ping me for request information.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

(In reply to tt_1 from comment #5)

ehm, you might want to fix this properly? Right now there's no cve against rust, but something as CVE-2019-12083 might happen again. I agree that the informations provided aren't awfully helpfull, I can provide a build log with the errors to ease debugging this. Just ping me for request information.

I understand the failure mode, see the rust-lang issue linked in comment 2. I don't know how this would be a security issue, at least in the bindgen case, where it's just a build tool?

That is, what do you mean with "fixing it properly"? This is properly fixed on bindgen and on trunk already.

Comment 7

[tt_1]

Right now it doesn't matter much, since there's no open cve against any version of rust. In my opinion it would be a wise move to backport the fix for this issue to esr, and possibly to the v70.0 branch, so that you're not caught by surprise if any cve is filled against rust in the future.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Ah, I see what you mean. Yeah, backporting the build fix to ESR should be straight-forward should it be needed... Probably not worth backporting to 70 at this point.