1594828 - Reader mode should change to dark theme automatically like Safari

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, enhancement)

Description

[sheelgautam995]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:70.0) Gecko/20100101 Firefox/70.0

Actual results:

When system changes to dark theme, Firefox changes to dark theme as well. Reader mode requires manually changing theme. It creates a flash of white light.

Expected results:

It should work like Safari. Safari automatically changes the default theme of Reader mode to dark.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[sheelgautam995]

Firefox changes to dark theme automatically with MacOS. Reader mode should open with dark theme when its activated while Firefox is in dark mode. Otherwise it will create a light flash which defeats the purpose of dark mode. Currently, it opens in whatever theme the user has set it to.

Comment 3

[erik]

I agree. Using Firefox 73 on Fedora 31 with dark Gnome theme ($ gsettings set org.gnome.desktop.interface gtk-theme 'Adwaita-dark'
) I expect reader mode to default to dark theme.

Comment 5

[kabakert]

Attachment: Bug 1594828 - Changed Reader Mode color scheme preference to be based off of browser content theme. r=mtigley,niklas

Depends on D136065

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6688f6cc420b
Changed Reader Mode color scheme preference to be based off of browser content theme. r=mtigley,niklas

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/6688f6cc420b

Comment 8

[Donal Meehan [:dmeehan]]

Looks like this could be added to the release notes for Fx99.
Could you provide the following info?
[Affects Firefox for Android]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Comment 9

[kabakert]

[Affects Firefox for Android]: (In reply to Donal Meehan [:dmeehan] from comment #8)

Looks like this could be added to the release notes for Fx99.
Could you provide the following info?

[Affects Firefox for Android]: Yes, however the user would need to manually set the 'reader.color_scheme' pref from the app itself, since we don't show the toolbar on android.
[Suggested wording]: 'Auto' is now offered as a fourth color scheme option in the Reader Mode toolbar, which allows the user to sync their Reader Mode color scheme preference with the browser's color scheme preference (light mode vs dark mode). This is currently hidden behind the new 'reader.improvements_H12022.enabled' pref, so users will need to flip/enable this pref if they want to use it.
[Links (documentation, blog post, etc)]: None

Comment 10

[Donal Meehan [:dmeehan]]

(In reply to kabakert from comment #9)

[Affects Firefox for Android]: (In reply to Donal Meehan [:dmeehan] from comment #8)

Looks like this could be added to the release notes for Fx99.
Could you provide the following info?

[Affects Firefox for Android]: Yes, however the user would need to manually set the 'reader.color_scheme' pref from the app itself, since we don't show the toolbar on android.
[Suggested wording]: 'Auto' is now offered as a fourth color scheme option in the Reader Mode toolbar, which allows the user to sync their Reader Mode color scheme preference with the browser's color scheme preference (light mode vs dark mode). This is currently hidden behind the new 'reader.improvements_H12022.enabled' pref, so users will need to flip/enable this pref if they want to use it.
[Links (documentation, blog post, etc)]: None

Thanks for the clarification this is behind a reader.improvements_H12022.enabled' pref and is disabled by default. I should have noticed before requesting release note information.
Will hold back on adding a release note until it's enabled by default.

Comment 12

[Jeff Fortin]

I've found a bug with this, but it's kind of a heisenbug; I'm not certain what triggers it, only that it does happen fairly regularly: bug #1766244