Closed Bug 1594844 Opened 5 years ago Closed 5 years ago

Automatically set the bug's assignee when they upload a revision to an unassigned bug

Categories

(bugzilla.mozilla.org :: Phabricator Integration, enhancement)

Production
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ng, Assigned: glob)

References

Details

When using moz-phab to submit a patch for review, it would be great if there was an option to self-assign a Bugzilla bug that currently has no assignee.

I love this idea, however it would be better for this action to be performed by Bugzilla itself when it binds the bug to the Phabricator revision.

The only downside of doing there is it cannot be optional; however, the act of submitting a revision for review to Phabricator is a very clear signal of ownership, so as long as the bug is currently assigned to nobody it should be the right course of action in most cases.

Component: moz-phab → Phabricator Integration
Product: Conduit → bugzilla.mozilla.org
Summary: Add flag or prompt to take and unassigned bug when a change set is uploaded → Automatically set the bug's assignee when they upload a revision to an unassigned bug
Version: unspecified → Production
Assignee: nobody → glob

Merged to master.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED

My thanks to everyone that worked on this. Every little bit of friction that is removed makes the whole experience so much smoother.

See Also: → 1599002
Depends on: 1599570
Regressions: 1605179
Regressions: 1606810

One side-effect is that new contributors can automatically claim a bug circumventing explicit triage owner / reviewer action. See bug 1525992.

While I haven't seen signs of abuse of this feature yet, it would be helpful to be able to conditionally disable it. Perhaps there's a feasible way to skip automated assignment if the patch author is a new contributor. Not sure if checking for at least Level 1 Commit Access is too restrictive.

(In reply to Razvan Caliman [:rcaliman] from comment #4)

One side-effect is that new contributors can automatically claim a bug circumventing explicit triage owner / reviewer action. See bug 1525992.

I don't see any circumventing of triage (the bug sat untriaged for a year, until the contributor picked it up), nor reviewers (gl appears to be the right reviewer).

While I haven't seen signs of abuse of this feature yet, it would be helpful to be able to conditionally disable it.

This is complicated and I think unnecessary; assigning a bug to someone who submits patches to it is a different task than ensuring that bugs are filed with an appropriate level of details around the constraints, and that they are triaged in a timely manner.

Note that even if a bug is unassigned that alone isn't enough to prevent reviewed code from landing; it wouldn't have impacted the outcome of bug 1525992 had you not raised your concerns there.

You need to log in before you can comment on or make changes to this bug.