1594892 - Remove xpidl [array] use in nsIMsgDatabase

Status: RESOLVED FIXED

(MailNews Core :: Backend, task)

Comment 1

[Ben Campbell]

Attachment: 1594892-part1-nsIMsgDatabase.MarkThreadRead-1.patch

nsIDatabase is biggie, so breaking it up by method.

Comment 2

[Ben Campbell]

Comment on attachment 9116804 [details] [diff] [review]
1594892-part1-nsIMsgDatabase.MarkThreadRead-1.patch

(doh - sorry... some chunks seem to have slipped out into another changeset. Will upload a new one.)

Comment 3

[Ben Campbell]

Attachment: 1594892-part1-nsIMsgDatabase.MarkThreadRead-2.patch

Comment 4

[Ben Campbell]

Attachment: 1594892-part2-nsIMsgDatabase.MarkAllRead-1.patch

Comment 5

[Ben Campbell]

Attachment: 1594892-part3-nsIMsgDatabase.deleteMessages-1.patch

Comment 6

[Ben Campbell]

Attachment: 1594892-part4-nsIMsgDatabase.getNewList-1.patch

Comment 7

[Ben Campbell]

Attachment: 1594892-part5-nsIMsgDatabase.refreshCache-1.patch

Last one, I think. I'll do a try run on the whole lot if I can find a short window of non-bustage :-)

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9116862 [details] [diff] [review]
1594892-part2-nsIMsgDatabase.MarkAllRead-1.patch

Review of attachment 9116862 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/db/msgdb/public/nsIMsgDatabase.idl
@@ +414,5 @@
>    boolean IsMarked(in nsMsgKey key);
>    /// Does the message have attachments.
>    boolean HasAttachments(in nsMsgKey key);
>  
> +  Array<nsMsgKey> MarkAllRead();

While we're changing, let's make it properly lower cased markAllRead. (Since all callers are cpp, no other changed needed.)

Comment 9

[Magnus Melin [:mkmelin]]

Sent it off to try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7f8863c01a153e12eed73628eee5fcee44f5d6f4

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/867262f56df2
xpidl [array] removal from nsIMsgDatabase.MarkThreadRead(). r=mkmelin
https://hg.mozilla.org/comm-central/rev/f6484bfeb6af
xpidl [array] removal from nsIMsgDatabase.MarkAllRead(). r=mkmelin
https://hg.mozilla.org/comm-central/rev/8f61543e6276
xpidl [array] removal from nsIMsgDatabase.deleteMessages(). r=mkmelin
https://hg.mozilla.org/comm-central/rev/fb1646d8e45c
'Bug 1594892 - xpidl [array] removal from nsIMsgDatabase.getNewList(). r=mkmelin
https://hg.mozilla.org/comm-central/rev/e68e4b9259f3
xpidl [array] removal from nsIMsgDatabase.refreshCache(). r=mkmelin

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1be1e6dac386
Follow-up: Reformat. rs=reformat DONTBUILD

Comment 12

[Jorg K (CEST = GMT+2)]

Formatting patches before they land would be great, and also checking commit messages :-(