Closed Bug 1594998 Opened 3 months ago Closed 3 months ago

Make standalone SpiderMonkey use libxul-like panic

Categories

(Core :: JavaScript Engine, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The full scope of bug 1582382 is a big can of worms, so let's only address the "easy" part for now. At the moment, I have something that mostly works for JS... but breaks building Firefox.

This moves the parts of toolkit/library/rust/shared/lib.rs related to
panic hooking to a new mozglue subdirectory, which will be used for
things that can be statically linked to e.g. libxul, rather than in
a "shared library".

The panic hook is disabled when building spidermonkey via the mozjs_sys
crate.

Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/4cf8f3f89042
Make standalone SpiderMonkey use libxul-like panic. r=froydnj,jandem
Backout by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cb4ea31e8593
Backed out changeset 4cf8f3f89042 for xpcshell failures at test_crash_rust_panic.js on a CLOSED TREE.

Backed out changeset 4cf8f3f89042 (bug 1594998) for xpcshell failures at test_crash_rust_panic.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/cb4ea31e85939ad29c536e0f1e360a244a982482

Push with failures (builds were busted on original push): https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=xpcshell&revision=4264dbdf0850c10c6f36806461126c52bd9b74f9&selectedJob=276120248

Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=276120248&repo=autoland

Log snippet:

[task 2019-11-14T01:51:04.397Z] 01:51:04 INFO - TEST-START | toolkit/crashreporter/test/unit/test_crash_rust_panic_multiline.js
[task 2019-11-14T01:51:04.756Z] 01:51:04 WARNING - TEST-UNEXPECTED-FAIL | toolkit/crashreporter/test/unit/test_crash_rust_panic_multiline.js | xpcshell return code: 0
[task 2019-11-14T01:51:04.757Z] 01:51:04 INFO - TEST-INFO took 354ms
[task 2019-11-14T01:51:04.757Z] 01:51:04 INFO - >>>>>>>

Flags: needinfo?(mh+mozilla)
Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/7a28c229e654
Make standalone SpiderMonkey use libxul-like panic. r=froydnj
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/4d53b9239b4a
Make standalone SpiderMonkey use libxul-like panic. r=froydnj
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Flags: needinfo?(mh+mozilla)
You need to log in before you can comment on or make changes to this bug.