1595052 - Incorrect height of download progress bar and misaligned progress indicator with HiDPI @150% and @175%

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect, P3)

Description

[Itiel]

Attachment: Screenshot

See attached.

Comment 1

[Itiel]

This is caused by this rule:
https://searchfox.org/mozilla-central/rev/b2b0077c2e6a516a76bf8077d6f0237c58f5959a/browser/themes/shared/downloads/progressmeter.inc.css#31-34
in combination with this:
https://searchfox.org/mozilla-central/rev/b2b0077c2e6a516a76bf8077d6f0237c58f5959a/browser/themes/shared/downloads/progressmeter.inc.css#18

Comment 2

[:Paolo Amadini]

The height looks correct for me on Windows 7, while in your screenshot both the full bar and the blue progress indication have the wrong height. The correct one should be 8px including 1px top and bottom border, leaving 6px for the light area. Which platform did you test with?

The styles were introduced bug 1499704, did you test revision 87a982cbe331 to see if they already looked incorrect there on your system? If not, we could get a regression range by bisecting starting from there (2018-10-19).

Comment 3

[Itiel]

*Sigh* Of course it had to be DPI-related...
100% and 125% are behaving OK, 150% and 175% are having issues (I don't have higher DPI options to test).

This has started between 2018-10-18 and 2018-10-19. As mozregression couldn't (and still can't) bisect further, and disabling the rule mentioned in comment 1 fixed this, I deduced this was caused by bug 1499704.
I'm on Windows 10.

Comment 4

[:Paolo Amadini]

Thank you for testing this! It seems likely this issue was present from the start in the new design.

As it may be caused by DPI rounding issues, I'm tentatively adding this to meta-bug 1443502.

Comment 5

[Dão Gottwald [:dao]]

Does bug 1722582 fix this?

Comment 6

[Itiel]

Thanks for pinging me, yes it does!
It looks a bit thinner now but I guess that's to be expected.