Support form autofill in out-of-process iframes
Categories
(Toolkit :: Form Autofill, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: enndeakin, Assigned: enndeakin)
References
Details
Attachments
(5 files, 1 obsolete file)
This involves the code in browser/extensions/formautofill/
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Assignee | ||
Comment 2•3 years ago
|
||
Depends on D52721
Assignee | ||
Comment 3•3 years ago
|
||
Depends on D52722
Updated•3 years ago
|
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ddd336d5bf1a replace the frame script FormAutofillFrameScript.js with an actor and fix up setTimeout calls in places that were relying on Timer.jsm being loaded in that frame script, r=MattN https://hg.mozilla.org/integration/autoland/rev/803a2dfdda82 change FormAutofillParent to inherit from JSWindowActor, r=MattN https://hg.mozilla.org/integration/autoland/rev/f512953534ac add a test for form fillin that uses a child iframe loaded in a separate process, r=MattN
Backout by apavel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/032f9bb031b3 Backed out 3 changesets for failing bc at browser_autocomplete_marked_detached_tab.js on a CLOSED TREE
Comment 6•3 years ago
|
||
Backed out for failing bc at browser_autocomplete_marked_detached_tab.js
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=277099701&repo=autoland&lineNumber=17054
Backout: https://hg.mozilla.org/integration/autoland/rev/032f9bb031b3275ecc0282daf39ae05ef046d197
Comment 7•3 years ago
|
||
Also please take a look over g1 talos failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&searchStr=g1%2Ctalos%2Cperformance%2Ctests%2C&tochange=26dedaf63bf56ad57d1ecb2a72fc6c87ca3d0765&fromchange=8f66f73bb335cbf15d125c8e434c403bb399f875&selectedJob=277115513
Logs: https://treeherder.mozilla.org/logviewer.html#?job_id=277115513&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=277113678&repo=autoland
Assignee | ||
Comment 8•3 years ago
|
||
The talos failure is just yet another setTimeout dependency. I'll add a patch for this.
I think the leak is easily fixable if willDestroy would be called -- this is bug 1596187. So I'm going to wait on that bug.
Assignee | ||
Comment 9•3 years ago
|
||
Depends on D52723
Assignee | ||
Comment 10•3 years ago
|
||
Depends on D54944
Comment 11•3 years ago
|
||
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/444505b4936b replace the frame script FormAutofillFrameScript.js with an actor and fix up setTimeout calls in places that were relying on Timer.jsm being loaded in that frame script, r=MattN https://hg.mozilla.org/integration/autoland/rev/7ffa8f958d0a change FormAutofillParent to inherit from JSWindowActor, r=MattN https://hg.mozilla.org/integration/autoland/rev/8ca3c106fc8d add a test for form fillin that uses a child iframe loaded in a separate process, r=MattN https://hg.mozilla.org/integration/autoland/rev/45481561c120 use content.setTimeout in talos frame scripts, r=mconley https://hg.mozilla.org/integration/autoland/rev/498f750ed88a make sure the message observer is removed after focus is complete in form autofill tests, also move removing of observer from willDestroy to didDestroy so it is more consistently called, r=MattN
Comment 12•3 years ago
|
||
Backed out 5 changesets (bug 1595154) for causing talos performance tests failures
push that casued the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=talos-svgr-e10s&revision=498f750ed88a865b2de94d5d1c1ff6df1b9453de&selectedJob=279620680
backout: https://hg.mozilla.org/integration/autoland/rev/23de678a741e2d98b9082ff9b3b2091ee9763875
Assignee | ||
Comment 13•3 years ago
|
||
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Comment 14•3 years ago
|
||
Landed:
- https://hg.mozilla.org/integration/autoland/rev/15d5f42d4c75bafd6b94bad2f0d635568a8e69e0
- https://hg.mozilla.org/integration/autoland/rev/ead1520e43f5ed86087e9d3381ddd3c4162d270e
- https://hg.mozilla.org/integration/autoland/rev/eed18052d88b50501d0aab07eddfbc6eaa5b91bd
- https://hg.mozilla.org/integration/autoland/rev/2ef14c4772aa82afb414f646fe9426cb4792e275
- https://hg.mozilla.org/integration/autoland/rev/818b1f70f80cbf1edca2217884d893011c0d68c9
Comment 15•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/15d5f42d4c75
https://hg.mozilla.org/mozilla-central/rev/ead1520e43f5
https://hg.mozilla.org/mozilla-central/rev/eed18052d88b
https://hg.mozilla.org/mozilla-central/rev/2ef14c4772aa
https://hg.mozilla.org/mozilla-central/rev/818b1f70f80c
Comment 16•3 years ago
|
||
== Change summary for alert #24478 (as of Fri, 13 Dec 2019 11:14:44 GMT) ==
Improvements:
0.29% Base Content JS windows10-64 opt 3,908,073.33 -> 3,896,868.00
0.29% Base Content JS windows10-64-qr opt 3,907,976.00 -> 3,896,746.67
0.29% Base Content JS windows10-64-qr opt 3,907,996.67 -> 3,896,704.00
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24478
Description
•