Closed Bug 1595154 Opened 11 months ago Closed 9 months ago

Support form autofill in out-of-process iframes

Categories

(Toolkit :: Form Autofill, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla73
Fission Milestone M5
Tracking Status
firefox73 --- fixed

People

(Reporter: enndeakin, Assigned: enndeakin)

References

(Blocks 1 open bug)

Details

Attachments

(5 files, 1 obsolete file)

This involves the code in browser/extensions/formautofill/

Priority: -- → P1
Fission Milestone: --- → M5
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ddd336d5bf1a
replace the frame script FormAutofillFrameScript.js with an actor and fix up setTimeout calls in places that were relying on Timer.jsm being loaded in that frame script, r=MattN
https://hg.mozilla.org/integration/autoland/rev/803a2dfdda82
change FormAutofillParent to inherit from JSWindowActor, r=MattN
https://hg.mozilla.org/integration/autoland/rev/f512953534ac
add a test for form fillin that uses a child iframe loaded in a separate process, r=MattN
Backout by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/032f9bb031b3
Backed out 3 changesets for failing bc at browser_autocomplete_marked_detached_tab.js on a CLOSED TREE

The talos failure is just yet another setTimeout dependency. I'll add a patch for this.

I think the leak is easily fixable if willDestroy would be called -- this is bug 1596187. So I'm going to wait on that bug.

Depends on: 1596187
Flags: needinfo?(enndeakin)
No longer depends on: 1596187
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/444505b4936b
replace the frame script FormAutofillFrameScript.js with an actor and fix up setTimeout calls in places that were relying on Timer.jsm being loaded in that frame script, r=MattN
https://hg.mozilla.org/integration/autoland/rev/7ffa8f958d0a
change FormAutofillParent to inherit from JSWindowActor, r=MattN
https://hg.mozilla.org/integration/autoland/rev/8ca3c106fc8d
add a test for form fillin that uses a child iframe loaded in a separate process, r=MattN
https://hg.mozilla.org/integration/autoland/rev/45481561c120
use content.setTimeout in talos frame scripts, r=mconley
https://hg.mozilla.org/integration/autoland/rev/498f750ed88a
make sure the message observer is removed after focus is complete in form autofill tests, also move removing of observer from willDestroy to didDestroy so it is more consistently called, r=MattN
Attachment #9114737 - Attachment is obsolete: true
Attachment #9111953 - Attachment description: Bug 1595154, use content.setTimeout in talos frame scripts, r=mconley → Bug 1595154, Use a setTimeout available from content or window in talos frame scripts, r=mconley
Flags: needinfo?(enndeakin)
Regressions: 1603309

== Change summary for alert #24478 (as of Fri, 13 Dec 2019 11:14:44 GMT) ==

Improvements:

0.29% Base Content JS windows10-64 opt 3,908,073.33 -> 3,896,868.00
0.29% Base Content JS windows10-64-qr opt 3,907,976.00 -> 3,896,746.67
0.29% Base Content JS windows10-64-qr opt 3,907,996.67 -> 3,896,704.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24478

You need to log in before you can comment on or make changes to this bug.