Closed Bug 1595185 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 20184 - Add more scroll to text WPTs

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox72 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20184 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20184
Details from upstream follow.

Nick Burris <nburris@chromium.org> wrote:

Add more scroll to text WPTs

Adds more web platform tests for scroll to text:

  • Combination of non-text directive and text directive
  • Scroll second text directive into view if first doesn't match
  • Matching shadow DOM
  • Don't scroll to hidden text
  • Text that requires a horizontal scroll into view
  • Also fixed non-ASCII test case (and changed to Japanese example)

Change-Id: Id7e21a185897267dc565b19adc7bfdfb5fe70974
Reviewed-on: https://chromium-review.googlesource.com/1903624
WPT-Export-Revision: b06281470e90930d52c0950c7ff6f5b7a0f2c4bd

PR 20184 applied with additional changes from upstream: c1c27e227840599ad09a150f74851cbd9238c9b9, 186457c2f6c0f52d9939cddeefeaebcff38d681b
There were infrastructure failures for the Try push (https://treeherder.mozilla.org/#/jobs?repo=try&revision=273cd9ada022fe4088de0321cadd2aa8faf006a9):
build-android-x86_64/debug
build-win32/debug
build-win64/opt
build-win64/debug
build-win32/opt
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c4ffe8d76ac
[wpt PR 20184] - Add more scroll to text WPTs, a=testonly

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests and 71 subtests

Firefox

PASS : 1
FAIL : 37
TIMEOUT: 1
ERROR : 1
NOTRUN : 2

Chrome

PASS : 1
FAIL : 37
TIMEOUT: 1
ERROR : 1
NOTRUN : 2

Safari

OK : 1
FAIL : 41

Existing tests that now have a worse result

/scroll-to-text-fragment/scroll-to-text-fragment.html
Test navigation with fragment: Empty hash: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: FAIL->MISSING

Other new tests that's don't pass

/scroll-to-text-fragment/scroll-to-text-fragment.html
Test navigation with fragment: Fragment directive with percent encoded syntactical characters "&,-" should match text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Non-matching text directive with existing element fragment should scroll to element.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Generic fragment directive with existing element fragment should scroll to element.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Exact text with prefix should match text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Multiple match text directive disambiguated by suffix should match the suffixed text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Exact text with suffix should match text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Text directive should match when context terms are separated by node boundaries.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Non-matching text directive with nonexistent element fragment should not match and not scroll.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Non-whole-word exact text with spaces should not match.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Text range with prefix and suffix should match text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Text directive should not scroll to hidden text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Multiple match text directive disambiguated by prefix should match the prefixed text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Text range with no context should match text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Text range with prefix and nonmatching suffix should not match.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Multiple non-whole-word exact texts should not match.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Multiple text directives and a non-text directive should match text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Text directive should match text within shadow DOM.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Text range with non-matching startText should not match.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Text directive with invalid syntax (context terms without "-") should not parse as a text directive.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Text directive with existing element fragment should match and scroll into view text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Multiple match text directive disambiguated by prefix and suffix should match the text with the given context.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Text range with non-matching endText should not match.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Text range with prefix should match text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Text range with suffix should match text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Text directive with nonexistent element fragment should match and scroll into view text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Text range with nonmatching prefix and matching suffix should not match.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Exact text with prefix and suffix should match text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Fragment directive with all TextMatchChars should match text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Exact text with percent encoded spaces should match text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: A non-matching text directive followed by a matching text directive should match and scroll into view the second text directive.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Text directive should not scroll to display none text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Uppercase TEXT directive should not parse as a text directive.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Multiple matching exact texts should match text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Fragment directive with percent encoded non-ASCII unicode character should match text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Exact text with no context should match text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Text directive should horizontally scroll into view.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test navigation with fragment: Text directive followed by non-text directive should match text.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL

https://hg.mozilla.org/mozilla-central/rev/8c4ffe8d76ac

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.