1595220 - [mozinfo] distro.linux_platform has different output compared to platform.linux_distribution

Status: RESOLVED FIXED

(Testing :: Mozbase, defect, P3)

Description

[Edwin Takahashi (:egao | infrequent contributor)]

With mozinfo 1.2.0 release the distro package is now the primary method used to provide the value for linux_distribution.

My assumption that it was a straight drop-in replacement was incorrect however. The output slightly differs as seen below:

>>> import platform
>>> platform.linux_distribution()
('debian', '10.1', '')
>>> import distro
>>> distro.linux_distribution()
(u'Debian GNU/Linux', u'10', u'buster')

Therefore it may be required to perform some or all of the following adjustments to the outputs:

• lowercase the output
• trim/prune

Additionally or alternatively:

• more tests should be written to catch this case.
• consider removing entirely the usage of platform module (even though python2.7 and python3.5 still supports platform)

Comment 1

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1595220 - streamline and sanitize output of distro/platform linux_distribution call in mozinfo

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b4f0fb8292c
streamline and sanitize output of distro/platform linux_distribution call in mozinfo r=jmaher

Comment 3

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=4b4f0fb8292c18cd114e92ed3f1c57f187a7d5eb&searchStr=wr&selectedJob=275944381

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=275944381&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=275944405&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/f644542d11c15980eed8368d5b52539d571c35ce

Also these wpts: https://treeherder.mozilla.org/logviewer.html#?job_id=275944408&repo=autoland

Comment 4

[Edwin Takahashi (:egao | infrequent contributor)]

Not sure why this would change those test results, that seems very strange and unexpected.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d5e40454c30
streamline and sanitize output of distro/platform linux_distribution call in mozinfo r=jmaher

Comment 6

[Edwin Takahashi (:egao | infrequent contributor)]

Pushed a fixed patch.

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/3d5e40454c30