Closed Bug 1595249 Opened 6 years ago Closed 6 years ago

Touch Bar Customization is (Sometimes) Missing Labels and Icons

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1595082

People

(Reporter: shorlander, Unassigned)

References

Details

Attachments

(1 file)

Attached image touch-bar-broken.png

Sometimes when I open the "Customize Touch Bar…" UI it is missing icons and labels.

I'm not entirely sure what's causing this, because it seems to depend on which window I start the customization on.

Does bug 1595082 cover this?

Flags: needinfo?(shorlander)

(In reply to Stephen A Pohl [:spohl] from comment #1)

Does bug 1595082 cover this?

It seems similar, but doesn't mention the ❗️MISSING LABEL❗️ issue.

Flags: needinfo?(shorlander)

(In reply to Stephen Horlander [:shorlander] (If you're waiting on a response please ping me on Slack or IRC) from comment #2)

(In reply to Stephen A Pohl [:spohl] from comment #1)

Does bug 1595082 cover this?

It seems similar, but doesn't mention the ❗️MISSING LABEL❗️ issue.

Thanks! Are the missing labels still an issue for you after the landing of bug 1591839? The fix should be in either current Nightly or next.

Flags: needinfo?(shorlander)

(In reply to Stephen A Pohl [:spohl] from comment #3)

(In reply to Stephen Horlander [:shorlander] (If you're waiting on a response please ping me on Slack or IRC) from comment #2)

(In reply to Stephen A Pohl [:spohl] from comment #1)

Does bug 1595082 cover this?

It seems similar, but doesn't mention the ❗️MISSING LABEL❗️ issue.

Thanks! Are the missing labels still an issue for you after the landing of bug 1591839? The fix should be in either current Nightly or next.

Still happening in the latest Nightly.

Flags: needinfo?(shorlander) → needinfo?(spohl.mozilla.bugs)

Harry, setting n-i in case you haven't seen this yet. Thanks!

Flags: needinfo?(spohl.mozilla.bugs) → needinfo?(htwyford)

Does this still happen in windows that were opened after bug 1591839 landed? It might still affect windows that have been open continuously/restored continuously since before bug 1591839 landed. The STR I found for this was

  1. Open a new window.
  2. Close that window.
  3. Open a new window.
  4. Open the Touch Bar customization window.

Before bug 1591839, there were both strings and icons missing. Now it should just be the icons.

Flags: needinfo?(htwyford) → needinfo?(shorlander)

(In reply to Harry Twyford [:harry] from comment #6)

Does this still happen in windows that were opened after bug 1591839 landed? It might still affect windows that have been open continuously/restored continuously since before bug 1591839 landed. The STR I found for this was

  1. Open a new window.
  2. Close that window.
  3. Open a new window.
  4. Open the Touch Bar customization window.

Before bug 1591839, there were both strings and icons missing. Now it should just be the icons.

Based on comment 3 and comment 4, yes, it sounds like it does.

Flags: needinfo?(shorlander)

My thinking was that the issue might only be affecting windows that haven't been closed in a few days, except for their being closed then restored to update Nightly. I can't reproduce the MISSING LABEL issue anymore, but I'm working on a fix for bug 1595082. I'll follow-up with shorlander when it lands to see if it fixes this issue for him as well.

See Also: → 1595082

Yeah, the labels seem fixed on new windows and I closed and restored my old window and they were fixed there as well. Icons still missing in some cases.

Glad to hear it! There's a patch up for review for the missing icons over in bug 1595082. I'll mark this as duplicate.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: