Closed Bug 1595340 Opened 5 years ago Closed 4 years ago

Intermittent fission browser/components/extensions/test/browser/browser_ext_urlbar.js | "about:blank" == "http://example.com/" - JS frame :: chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_urlbar.js

Categories

(Firefox :: Address Bar, defect, P5)

Product:
Firefox
Component:
Address Bar
Type:
defect
Points:
3

Tracking

()

Status:
RESOLVED INCOMPLETE
Iteration:
72.2 - Nov 4 - 17
Project Flags:
Fission Milestone M4.1

People

(Reporter: intermittent-bug-filer, Assigned: adw)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1595340 - re-enable browser_ext_urlbar.js on fission r=cpeterson
47 bytes, text/x-phabricator-request
Details | Review

Filed by: apavel [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=275495387&repo=mozilla-central
Full log: https://queue.taskcluster.net/v1/task/BGhWNVI4QYyA3K7PwoEcsg/runs/0/artifacts/public/logs/live_backing.log

[task 2019-11-09T16:53:47.026Z] 16:53:47 INFO - GECKO(1178) | ++DOMWINDOW == 7 (0x7f7b28f25000) [pid = 1312] [serial = 418] [outer = 0x7f7b29502200]
[task 2019-11-09T16:53:47.100Z] 16:53:47 INFO - TEST-START | browser/components/extensions/test/browser/browser_ext_urlbar.js
[task 2019-11-09T16:53:47.136Z] 16:53:47 INFO - GECKO(1178) | ++DOMWINDOW == 8 (0x7f7b28f2e800) [pid = 1312] [serial = 419] [outer = 0x7f7b29502200]
[task 2019-11-09T16:53:47.232Z] 16:53:47 INFO - GECKO(1178) | 1573318427226 addons.webextension.<unknown> WARN Loading extension 'undefined': Reading manifest: Invalid extension permission: urlbar
[task 2019-11-09T16:53:47.310Z] 16:53:47 INFO - GECKO(1178) | [Parent 1178, Main Thread] WARNING: Need BrowserChild to get the nativeWindow from!: file /builds/worker/workspace/build/src/widget/PuppetWidget.cpp, line 1095
[task 2019-11-09T16:53:47.311Z] 16:53:47 INFO - GECKO(1178) | ++DOCSHELL 0x7f799bbbd000 == 5 [pid = 1232] [id = {53d52cfc-8d09-466d-bc86-bdd7a15b9162}]
[task 2019-11-09T16:53:47.311Z] 16:53:47 INFO - GECKO(1178) | ++DOMWINDOW == 19 (0x7f799bca5f20) [pid = 1232] [serial = 2086] [outer = (nil)]
[task 2019-11-09T16:53:47.326Z] 16:53:47 INFO - GECKO(1178) | ++DOMWINDOW == 20 (0x7f799bc40c00) [pid = 1232] [serial = 2087] [outer = 0x7f799bca5f20]
[task 2019-11-09T16:53:47.346Z] 16:53:47 INFO - GECKO(1178) | [Child 1232, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/workspace/build/src/dom/ipc/BrowserChild.cpp, line 2700
[task 2019-11-09T16:53:47.390Z] 16:53:47 INFO - GECKO(1178) | ++DOMWINDOW == 21 (0x7f799bcebc00) [pid = 1232] [serial = 2088] [outer = 0x7f799bca5f20]
[task 2019-11-09T16:53:47.902Z] 16:53:47 INFO - GECKO(1178) | 1573318427900 addons.webextension.<unknown> WARN Loading extension 'undefined': Reading manifest: Invalid extension permission: urlbar
[task 2019-11-09T16:53:47.956Z] 16:53:47 INFO - GECKO(1178) | [Parent 1178, Main Thread] WARNING: Need BrowserChild to get the nativeWindow from!: file /builds/worker/workspace/build/src/widget/PuppetWidget.cpp, line 1095
[task 2019-11-09T16:53:47.972Z] 16:53:47 INFO - GECKO(1178) | ++DOCSHELL 0x7f799bbc0000 == 6 [pid = 1232] [id = {6a8ceba0-cfb3-4309-a5da-175ca2ddcd24}]
[task 2019-11-09T16:53:47.973Z] 16:53:47 INFO - GECKO(1178) | ++DOMWINDOW == 22 (0x7f799bca6100) [pid = 1232] [serial = 2089] [outer = (nil)]
[task 2019-11-09T16:53:47.973Z] 16:53:47 INFO - GECKO(1178) | ++DOMWINDOW == 23 (0x7f799bc4b800) [pid = 1232] [serial = 2090] [outer = 0x7f799bca6100]
[task 2019-11-09T16:53:47.988Z] 16:53:47 INFO - GECKO(1178) | [Child 1232, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/workspace/build/src/dom/ipc/BrowserChild.cpp, line 2700
[task 2019-11-09T16:53:48.004Z] 16:53:48 INFO - GECKO(1178) | ++DOMWINDOW == 24 (0x7f799bde3c00) [pid = 1232] [serial = 2091] [outer = 0x7f799bca6100]
[task 2019-11-09T16:53:48.344Z] 16:53:48 INFO - GECKO(1178) | 1573318428335 addons.webextension.<unknown> WARN Loading extension 'undefined': Reading manifest: Invalid extension permission: urlbar
[task 2019-11-09T16:53:48.387Z] 16:53:48 INFO - GECKO(1178) | [Parent 1178, Main Thread] WARNING: Need BrowserChild to get the nativeWindow from!: file /builds/worker/workspace/build/src/widget/PuppetWidget.cpp, line 1095

[task 2019-11-09T16:53:53.370Z] 16:53:53 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_urlbar.js | "http://example.com/" == "http://example.com/" -
[task 2019-11-09T16:53:53.371Z] 16:53:53 INFO - Leaving test bound tip_onResultPicked_mainButton_url_mouse
[task 2019-11-09T16:53:53.371Z] 16:53:53 INFO - Entering test bound tip_onResultPicked_helpButton_url_enter
[task 2019-11-09T16:53:53.376Z] 16:53:53 INFO - Extension loaded
[task 2019-11-09T16:53:53.376Z] 16:53:53 INFO - Console message: Warning: attempting to write 34838 bytes to preference extensions.webextensions.uuids. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
[task 2019-11-09T16:53:53.377Z] 16:53:53 INFO - Console message: 1573318431439 addons.webextension.<unknown> WARN Loading extension 'undefined': Reading manifest: Invalid extension permission: urlbar
[task 2019-11-09T16:53:53.377Z] 16:53:53 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_urlbar.js | Provider should have been registered - {"_name":"test","_eventListeners":{},"behavior":"inactive"} == true -
[task 2019-11-09T16:53:53.378Z] 16:53:53 INFO - Buffered messages finished
[task 2019-11-09T16:53:53.378Z] 16:53:53 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_urlbar.js | "about:blank" == "http://example.com/" - JS frame :: chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_urlbar.js :: tip_onResultPicked_helpButton_url_enter/< :: line 175
[task 2019-11-09T16:53:53.378Z] 16:53:53 INFO - Stack trace:
[task 2019-11-09T16:53:53.379Z] 16:53:53 INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_urlbar.js:tip_onResultPicked_helpButton_url_enter/<:175
[task 2019-11-09T16:53:53.379Z] 16:53:53 INFO - resource://testing-common/BrowserTestUtils.jsm:withNewTab:151
[task 2019-11-09T16:53:53.379Z] 16:53:53 INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_urlbar.js:tip_onResultPicked_helpButton_url_enter:160
[task 2019-11-09T16:53:53.380Z] 16:53:53 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1069
[task 2019-11-09T16:53:53.380Z] 16:53:53 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2019-11-09T16:53:53.380Z] 16:53:53 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:932
[task 2019-11-09T16:53:53.381Z] 16:53:53 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805
[task 2019-11-09T16:53:53.382Z] 16:53:53 INFO - GECKO(1178) | [Child 1860, Main Thread] WARNING: Trying to request nsIHttpChannel from DocumentChannelChild, this is likely broken: file /builds/worker/workspace/build/src/netwerk/ipc/DocumentChannelChild.cpp, line 44
[task 2019-11-09T16:53:53.382Z] 16:53:53 INFO - GECKO(1178) | [Child 1860, Main Thread] WARNING: Trying to request nsIHttpChannel from DocumentChannelChild, this is likely broken: file /builds/worker/workspace/build/src/netwerk/ipc/DocumentChannelChild.cpp, line 44
[task 2019-11-09T16:53:53.383Z] 16:53:53 INFO - GECKO(1178) | [Child 1860, Main Thread] WARNING: NS_ENSURE_TRUE(request) failed: file /builds/worker/workspace/build/src/netwerk/base/nsLoadGroup.cpp, line 575
[task 2019-11-09T16:53:53.384Z] 16:53:53 INFO - Leaving test bound tip_onResultPicked_helpButton_url_enter
[task 2019-11-09T16:53:53.385Z] 16:53:53 INFO - Entering test bound tip_onResultPicked_helpButton_url_mouse
[task 2019-11-09T16:53:53.385Z] 16:53:53 INFO - Extension loaded
[task 2019-11-09T16:53:53.386Z] 16:53:53 INFO - Console message: Warning: attempting to write 34918 bytes to preference extensions.webextensions.uuids. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
[task 2019-11-09T16:53:53.387Z] 16:53:53 INFO - GECKO(1178) | --DOMWINDOW == 7 (0x7fb8d4fb2000) [pid = 1254] [serial = 235] [outer = (nil)] [url = about:newtab]
[task 2019-11-09T16:53:53.387Z] 16:53:53 INFO - GECKO(1178) | --DOMWINDOW == 6 (0x7fb8d4f1f400) [pid = 1254] [serial = 240] [outer = (nil)] [url = about:blank]
[task 2019-11-09T16:53:53.391Z] 16:53:53 INFO - GECKO(1178) | 1573318432960 addons.webextension.<unknown> WARN Loading extension 'undefined': Reading manifest: Invalid extension permission: urlbar
[task 2019-11-09T16:53:53.392Z] 16:53:53 INFO - Console message: 1573318432960 addons.webextension.<unknown> WARN Loading extension 'undefined': Reading manifest: Invalid extension permission: urlbar
[task 2019-11-09T16:53:53.392Z] 16:53:53 INFO - GECKO(1178) | [Parent 1178, Main Thread] WARNING: Need BrowserChild to get the nativeWindow from!: file /builds/worker/workspace/build/src

Regressed by: 1594622
Keywords: regression

The test task opens the urlbar view, where the tip button should be preselected. Then it sends a down arrow key, which should select the tip's help button. Then it sends an enter key, which should pick the selected help button and open example.com in the current tab.

But instead, the test ends up with about:blank in the current tab. Note that the test task starts by opening about:blank in a new tab.

A try push with some logging: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa0a4e28eb0cc81bf31dcdb2c8a5dc6b1941a8d0

Assignee: nobody → adw
Status: NEW → ASSIGNED
Iteration: --- → 72.2 - Nov 4 - 17
Points: --- → 3

The failure happened, but not enough info in the log to tell why. More logging: https://treeherder.mozilla.org/#/jobs?repo=try&revision=69234e33078954dfb916e16c6ecc603e1eb8425d

So I've been debugging a problem with the Temporary Containers extension over on GitHub and thanks to this bug report, I was able to discover that when you have fission.autostart = true, Nightly wants to open about:blank before each left-click and this has the unintended side effect of loading about:blank in the parent tab and and the clicked link in a new tab, completely destroying the navigation flow.

Our discussion and STR https://github.com/stoically/temporary-containers/issues/317

The problem disappears completely when I disable fission.

Thanks for that info. I haven't worked on this in a couple of days and I'm not sure when I'll get back to it, but that sounds helpful.

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → ?

Blocks Fission mochitests milestone (M4.1)

Fission Milestone: ? → M4.1

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Address Bar
Product: WebExtensions → Firefox

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE

Two users on reddit are reporting that they still see this problem: https://www.reddit.com/r/firefox/comments/h9nijv/announcing_fission_dogfooding/fuygd6d/

Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

Or maybe it would be better to file a new bug.

(In reply to Tom Schuster [:evilpie] from comment #25)

Two users on reddit are reporting that they still see this problem: https://www.reddit.com/r/firefox/comments/h9nijv/announcing_fission_dogfooding/fuygd6d/

Drew, should we open a new bug for the container extension problems users are reporting? Or does this intermittent browser_ext_urlbar.js test failure have the same root cause?

Flags: needinfo?(adw)

They may have the same root cause (I just don't know), but it would be better to open another bug for the container extension problem and maybe mark it see-also. I don't think it's a good idea to track a user- or developer-facing problem in an intermittent test failure bug.

Flags: needinfo?(adw)
See Also: → 1648211

(In reply to Drew Willcoxon :adw from comment #28)

They may have the same root cause (I just don't know), but it would be better to open another bug for the container extension problem and maybe mark it see-also. I don't think it's a good idea to track a user- or developer-facing problem in an intermittent test failure bug.

Thanks. I filed new bug 1648211 for the container extension problem.

I'll re-close this bug as INCOMPLETE since no intermittent test failures have been reported in the last four months.

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Resolution: --- → INCOMPLETE

Reopening this bug because this browser_ext_urlbar.js test is still disabled for Fission Linux. We should try re-enabling it.

https://searchfox.org/mozilla-central/rev/82c04b9cad5b98bdf682bd477f2b1e3071b004ad/browser/components/extensions/test/browser/browser.ini#279-280

[browser_ext_urlbar.js]
skip-if = (fission && os == 'linux' && os_version == '18.04')  # Bug 1595340 for linux1804

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b910ff6a9d38
re-enable browser_ext_urlbar.js on fission r=cpeterson
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: