1595414 - Not saving Google/Gmail passwords if the password field is revealed/unmasked

Status: VERIFIED FIXED

(Toolkit :: Password Manager: Site Compatibility, defect, P2)

Description

[hawran]

Attachment: Screenshot_2019-11-10_19-16-33.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

1. Start (a new installed) firefox in a safe mode.
2. Go to the gmail.com site.
3. Firefox offers accounts I've used before (on the other day).
4. There is NO a password autocompletion offered (the password field remains empty).
5. When the password is entered, NO "Save a password" notification appears.
6. Continue within my gmail account normally.
7. Log out and close firefox.
8. Go to #1

Actual results:

• NO "Save a password" notification appears
• NO password is saved for any gmail account.

Expected results:

• That "Save a password" notification appears.
• Passwords saved / autofilled for a next session.

Firefox Info:
Name Firefox
Version 70.0.1
Build ID 20191031085722
User Agent Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0
OS Linux 5.0.0-32-generic

NB The strange thing to notice: As I've used this (new installed) FF to log in to this site, I had to fill in the password, the "Save a password" notification has appeared and the password seems to be saved. Is it a something just the gmail.com site related?

Comment 1

[hawran]

Regarding the session screenshot, there are not any Exceptions within the Saved Passwords settings.

Comment 2

[Sam Foster [:sfoster] (PTO until 2026-01-05) (he/him)]

Would you be able to enable debug logging and attach the output to this bug? We log out details that will help track down what is going on here.

https://wiki.mozilla.org/Toolkit:Password_Manager/Debugging

Comment 3

[Matthew N. [:MattN]]

(In reply to hawran from comment #0)

3. Firefox offers accounts I've used before (on the other day).
4. There is NO a password autocompletion offered (the password field remains empty).
5. When the password is entered, NO "Save a password" notification appears.

Did you use the toggle to reveal/unmask the password? Was it still revealed when you clicked the button? If so, this depends on bug 1551730.

Comment 4

[hawran]

(In reply to Sam Foster [:sfoster] (he/him) from comment #2)

Would you be able to enable debug logging and attach the output to this bug? We log out details that will help track down what is going on here.

https://wiki.mozilla.org/Toolkit:Password_Manager/Debugging

There are no any messages like these:

LoginManagerContent: onDOMFormHasPassword for https://www.google.com
LoginManager: Counting logins matching host: https://www.google.com, formSubmitURL:  httpRealm: null

within the <F12> / Console window.

Comment 5

[hawran]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #3)

(In reply to hawran from comment #0)

3. Firefox offers accounts I've used before (on the other day).
4. There is NO a password autocompletion offered (the password field remains empty).
5. When the password is entered, NO "Save a password" notification appears.

Did you use the toggle to reveal/unmask the password? Was it still revealed when you clicked the button? If so, this depends on bug 1551730.

Yep, that's the point!

I've tried it again conscientiously and I can confirm that when I when I toggle to reveal/unmask the password - even though without any password being saved - just to be sure I enter the correct one, there is NO "Save a password" notification.
Hence no password saved.

Comment 6

[Matthew N. [:MattN]]

(In reply to hawran from comment #4)

There are no any messages like these … within the <F12> / Console window.

That's the wrong window/console (see the instructions) but it seems like we already figured out the cause so there's no longer a need for those logs.

Comment 7

[Alin Ilea, Desktop Test Engineering]

Hi,

This issue is also reproducible on https://www.linkedin.com using latest Release 72.0.2, Beta 73.0b8 and Nightly 74.0a1. I will update the flags accordingly.

Comment 8

[Alin Ilea, Desktop Test Engineering]

Attachment: logg.txt

Comment 9

[Matthew N. [:MattN]]

This issue should be fixed in today's Firefox Nightly. It would be great to test on Nightly with Google and LinkedIn to verify.

Comment 10

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Nightly 76.0a1 (build id: 20200329214909) using Windows 10 and Ubuntu 18.04. The issue is no longer reproducible, verified on gmail.com and LinkedIn.