Closed
Bug 1595482
Opened 5 years ago
Closed 5 years ago
Change name of responsiveness field
Categories
(Core :: Gecko Profiler, task, P1)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla72
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: jesup, Assigned: jesup)
References
Details
Attachments
(1 file)
This lets the front-end code know whether to create an event delay track.
Assignee | ||
Comment 1•5 years ago
|
||
Comment 2•5 years ago
•
|
||
Thanks for the patch. Front-end changes should be merged first to be able to handle the upgrading. See here: https://github.com/firefox-devtools/profiler/pull/2303
Type: defect → task
Priority: -- → P1
Updated•5 years ago
|
Attachment #9107825 -
Attachment description: Bug 1595482: change "responsiveness" field to "event_delay" in profiler r=gregtatum → Bug 1595482: change "responsiveness" field to "eventDelay" in profiler r=gregtatum
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/autoland/rev/70738ac7ba9b
change "responsiveness" field to "eventDelay" in profiler r=canaltinova
Comment 4•5 years ago
|
||
Backed out for xpcshell failures on test_responsiveness.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/76886efb06b40b8b9934f15e34150335c46c9c82
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276029199&repo=autoland&lineNumber=2693
Flags: needinfo?(rjesup)
Ah, we have a test for responsiveness
here: https://searchfox.org/mozilla-central/rev/cac340f10816707e91c46db6d285f80259420f07/tools/profiler/tests/xpcshell/test_responsiveness.js#26. We should also change that to eventDelay
.
Updated•5 years ago
|
Attachment #9107825 -
Attachment description: Bug 1595482: change "responsiveness" field to "eventDelay" in profiler r=gregtatum → Bug 1595482: change "responsiveness" field to "eventDelay" in profiler r=canaltinova
Assignee | ||
Updated•5 years ago
|
Flags: needinfo?(rjesup)
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/autoland/rev/9afdb269ce04
change "responsiveness" field to "eventDelay" in profiler r=canaltinova
Comment 7•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•