Closed
Bug 1595500
Opened 5 years ago
Closed 5 years ago
Running JS reftests creates ~1200 globals on startup
Categories
(Testing :: Reftest, enhancement)
Tracking
(firefox72 fixed)
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
I ran the JS reftests with some logging inserted and found that we create nearly 1200 globals on startup. This seems excessive.
It turns out that we create a sandbox for every manifest file read:
https://searchfox.org/mozilla-central/source/layout/tools/reftest/manifest.jsm#63
These sandboxes are not always uses, so we should be able to get away with creating them on demand.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
The patch reduces the number of sandboxes created to around 200.
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → jcoppeard
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9776aa076f9a Create reftest sandboxes on demand since they are often not required r=jmaher
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•