Closed Bug 1595528 Opened 4 years ago Closed 4 years ago

In-tree Puppeteer unit tests and examples don't work with Chrome/Chromium

Categories

(Remote Protocol :: Agent, defect, P1)

defect

Tracking

(firefox72 fixed)

RESOLVED FIXED
Firefox 72
Tracking Status
firefox72 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [puppeteer-alpha])

Attachments

(3 files)

I'm trying to run the puppeteer examples and for that I need the node command. As such I run npm install . from inside the puppeteer folder first. It by default downloads Chromium, installs it, and tries to start it to check the websocket connection. Sadly this doesn't work from our clone of the puppeteer repository inside mozilla-central. I can only get it working from an official clone of the repository.

Steps:

  1. Change into remote/test/puppeteer
  2. Run npm install .

The same happens for mach when trying to run with Chrome as product:

  1. Run mach puppeteer-test --product chrome

In both situation I get a timeout thrown.

Flags: needinfo?(mjzffr)

Oh, do we still have the stdout workaround in place? Given that Chrome only reads from stderr this clearly could be the problem. So stdout should only be used for Firefox for the time being.

The attached patch will allow us to run both Chrome and Firefox with the Puppeteer fork from Andreas which we merge into mozilla-central. This is a temporary workaround until bug 1543115 has been fixed, and necessary for better protocol debugging capabilities.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: -- → P1
See Also: → 1543115
Whiteboard: [puppeteer-alpha]

The Github PR got landed as:
https://github.com/andreastt/puppeteer/commit/a787de9d29b677e9363fad656077e3d981431186

I will have a patch soon for vendoring in those changes.

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf5bee09a2fc
[remote] Vendor in latest puppeteer changes. r=remote-protocol-reviewers,maja_zf
https://hg.mozilla.org/integration/autoland/rev/ac269d3b3155
[remote] Add local Chromium folder to ignore list. r=remote-protocol-reviewers,maja_zf
Summary: "mach puppeteer-test --product chrome" and "npm install ." fails due to no websocket connection to Chrome → In-tree Puppeteer unit tests and examples don't work with Chrome/Chromium
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: