1595528 - In-tree Puppeteer unit tests and examples don't work with Chrome/Chromium

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

I'm trying to run the puppeteer examples and for that I need the node command. As such I run npm install . from inside the puppeteer folder first. It by default downloads Chromium, installs it, and tries to start it to check the websocket connection. Sadly this doesn't work from our clone of the puppeteer repository inside mozilla-central. I can only get it working from an official clone of the repository.

Steps:

1. Change into remote/test/puppeteer
2. Run npm install .

The same happens for mach when trying to run with Chrome as product:

1. Run mach puppeteer-test --product chrome

In both situation I get a timeout thrown.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Oh, do we still have the stdout workaround in place? Given that Chrome only reads from stderr this clearly could be the problem. So stdout should only be used for Firefox for the time being.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Attachment: GitHub Pull Request (temporary fix)

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

The attached patch will allow us to run both Chrome and Firefox with the Puppeteer fork from Andreas which we merge into mozilla-central. This is a temporary workaround until bug 1543115 has been fixed, and necessary for better protocol debugging capabilities.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

The Github PR got landed as:
https://github.com/andreastt/puppeteer/commit/a787de9d29b677e9363fad656077e3d981431186

I will have a patch soon for vendoring in those changes.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=96ac1529185ac2b0428aa802c181a0ac49cf89a8

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Attachment: Bug 1595528 - [remote] Vendor in latest puppeteer changes. r=#remote

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Attachment: Bug 1595528 - [remote] Add local Chromium folder to ignore list. r=#remote

Depends on D52740

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf5bee09a2fc
[remote] Vendor in latest puppeteer changes. r=remote-protocol-reviewers,maja_zf
https://hg.mozilla.org/integration/autoland/rev/ac269d3b3155
[remote] Add local Chromium folder to ignore list. r=remote-protocol-reviewers,maja_zf

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/bf5bee09a2fc
https://hg.mozilla.org/mozilla-central/rev/ac269d3b3155