1595617 - gfxFontEntry's ForgetHBFace() and ReleaseGrFace() methods do not need to be virtual

Status: RESOLVED FIXED

(Core :: Graphics: Text, enhancement)

Description

[Jonathan Kew [:jfkthame]]

The only overrides of these methods are in gfxFontconfigFontEntry, and all it does is call through to the base implementations. I guess there was a time when it needed to do something different, but now the overrides can be removed and the methods de-virtualized; there's no reason to pay virtual-call overhead for them.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1595617 - Remove 'virtual' from a couple of gfxFontEntry methods that don't need to be overridden. r=lsalzman

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4aba265c9d1
Remove 'virtual' from a couple of gfxFontEntry methods that don't need to be overridden. r=lsalzman

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b4aba265c9d1