1595620 - Considering aliasing -webkit-font-feature-settings to font-feature-settings for webcompat

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Thomas Wisniewski [:twisniewski]]

As discussed in this Reddit thread, Japanese Wikipedia pages are using -webkit-font-feature-settings instead of font-feature-settings, which is causing some characters to use the wrong font in Firefox. As such we ought to consider supporting the prefix as an alias for webcompat's sake.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Adding "webkit" to extra_prefixes here + a test should do, if the syntax is the same.

Comment 2

[Mark]

Hey, could I please work on this bug? I'm completely new to this so any tips would be appreciated.

Comment 3

[Mark]

Attachment: Bug 1595620

Added "webkit" to extra_prefixes

Comment 4

[Mark]

Attachment: Bug 1595620 Added "webkit" to extra_prefixes.r=emilio

Depends on D53325

Comment 5

[Mark]

Attachment: Bug 1595620 Add support for -webkit-font-feature-settings as an alias of font-feature-settings.r=emilio

Comment 6

[Mark]

Attachment: Bug 1595620 Add support for -webkit-font-feature-settings as an alias of font-feature-settings.r=emilio

Comment 7

[Mark]

Attachment: Bug 1595620 Add support for -webkit-font-feature-settings as an alias of font-feature-settings.r=emilio

Comment 8

[Mark]

Attachment: Bug 1595620 Add support for -webkit-font-feature-settings as an alias of font-feature-settings.r=emilio

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f07b485c29ad
Add support for -webkit-font-feature-settings as an alias of font-feature-settings.r=emilio

Comment 10

[Cristian Brindusan [:cbrindusan]]

Backed out changeset f07b485c29ad (Bug 1595620) for xpcshell failures at test_css-properties-db.js.

https://hg.mozilla.org/integration/autoland/rev/8680f0205149f322f6646c4d4db896f2ebbb5881

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=f07b485c29ada6728b414611b6a3da3e09e95d5b&selectedJob=277819347

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=277819347&repo=autoland&lineNumber=2569

Comment 11

[Sean Voisen (:svoisen)]

I think the devtools static database just needs updating to get this to stick. Maybe run ./mach devtools-css-db?

Comment 12

[Jens Hausdorf :jens1o [ni? me]]

Hey Emilio,
I think I need your help as a mentor for this. I created https://hg.mozilla.org/try/rev/48e258d13a58218dd9b690a8e09b49d398eb5e0b (basically Mark's patch with Sean's addition) and pushed it to try, but the when I run the build artifact it does not seem to have made a change. In DevTools, -webkit-font-feature-settings is marked as an Invalid property name. :( Could you please give me a pointer?

Comment 13

[Emilio Cobos Álvarez (:emilio)]

That patch has a bunch of unrelated formatting changes. Please remove them?

But the patch seems to work as expected after I build and re-run ./mach devtools-css-db. I get a diff like:

+  "-webkit-font-feature-settings": {
+    "isInherited": true,
+    "subproperties": [
+      "font-feature-settings"
+    ],
+    "supports": [],
+    "values": [
+      "inherit",
+      "initial",
+      "normal",
+      "revert",
+      "unset"
+    ]
+  },

Comment 14

[Jens Hausdorf :jens1o [ni? me]]

Attachment: Bug 1595620 - Add support for -webkit-font-feature-settings as an alias of font-feature-settings. r?emilio

Comment 15

[Jens Hausdorf :jens1o [ni? me]]

Turns out I pushed to try with artifact build enabled, which is not what I wanted here...

Comment 16

[Jens Hausdorf :jens1o [ni? me]]

Attachment: Bug 1595620 - Add support for -webkit-font-feature-settings as an alias of font-feature-settings. r?emilio

Comment 17

[Mike Taylor [:miketaylr]]

Jens, is this ready to land?

Comment 18

[Jens Hausdorf :jens1o [ni? me]]

(In reply to Mike Taylor [:miketaylr] from comment #17)

Jens, is this ready to land?

Hey Mike, in Phabricator, Emilio explained that I'll need to write an Intent to Prototype where I haven't felt ready about at that time. However, I now think that I can do that. I'll write an Intent to Prototype and if nothing comes back, I'll rebase the patch on latest trunk. :)

Comment 19

[Mike Taylor [:miketaylr]]

Ah! Sorry, I missed that comment. :)

Good luck, looking forward to reading the intent (and am supportive of it!)

Comment 20

[Jens Hausdorf :jens1o [ni? me]]

fyi, I sent the mail yesterday, but it seems it is stuck in the moderation queue as I had not been subscribed to the list at that time. I hope it will be approved in the next day(s).

Comment 21

[Jens Hausdorf :jens1o [ni? me]]

Mike, do you know whether that list is still moderated? I could think that due to the recent changes it's not on deck anymore? Do you have any suggestion on how to proceed?

Comment 22

[Mike Taylor [:miketaylr]]

Attachment: intent email

Hi Jens, it looks like it made it through. :)

Comment 23

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 24

[Karl Dubost💡 :karlcow]

Hey jens,

There's a small change requested by emilio
https://phabricator.services.mozilla.com/D53357#1623134
and push it to the finish line.
Can you do it? Or do you want someone else to finish it?

Comment 25

[Jens Hausdorf :jens1o [ni? me]]

Hey Karl,

due to time constraints, I unfortunately cannot fix this the current week, however I could hop on to this in the week.
Would that be okay or would you rather see this bug fixed asap by someone else?

Cheers,
Jens

Comment 26

[Karl Dubost💡 :karlcow]

next week will be great! Thanks.

Comment 27

[Jens Hausdorf :jens1o [ni? me]]

Attachment: Bug 1595620 - Add support for -webkit-font-feature-settings as an alias of font-feature-settings. r?emilio

Replaces https://phabricator.services.mozilla.com/D53357

Comment 28

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 29

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.

Comment 30

[Thomas Wisniewski [:twisniewski]]

https://treeherder.mozilla.org/jobs?repo=try&revision=c59d532c5ee07d027b29c357825767498c525ec9

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3680d74bc7a
Add support for -webkit-font-feature-settings as an alias of font-feature-settings. r=emilio

Comment 32

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/f3680d74bc7a

Comment 33

[Dave Letorey]

Related issues and pull requests

• Content PR
• FF release note PR
• BCD PR