Closed Bug 1595696 Opened 2 years ago Closed 2 years ago

Shift artifact namespace transformation to the job class definition

Categories

(Firefox Build System :: General, task)

Product:
Firefox Build System
Component:
General
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(firefox72 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file)

Bug 1595696 - Shift artifact namespace transformation to the job class definition. r?#firefox-build-system-reviewers
47 bytes, text/x-phabricator-request
Details | Review

When choosing a namespace to search for artifacts, in some cases we add .shippable or make other changes. (This code.) I propose moving that code into ArtifactJob and its subclasses so that it can be overridden more easily. For example, due to a recent change in Thunderbird, we no longer want to add .shippable.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/integration/autoland/rev/75ddc4b87f79
Shift artifact namespace transformation to the job class definition. r=chmanchester

https://hg.mozilla.org/mozilla-central/rev/75ddc4b87f79

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.