Overflow Menu not correctly aligned in Customize menu when using Compact Density
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
People
(Reporter: atrif, Assigned: Gijs)
References
(Regression)
Details
(Keywords: regression)
Attachments
(3 files)
Affected versions
- 71.0b9 (20191111170815)
- 72.0a1 (20191111215252)
- 70.0.1 (20191030021342)
Affected platforms
- Ubuntu 18.04
- macOS 10.14
- Windows 10x64
Steps to reproduce
- Open Firefox and go to Customize Menu.
- Select “Compact” from the “Density” dropdown.
Expected result
- Overflow Menu is updated accordingly.
Actual result
- Overflow Menu is displayed on the left side of the drop-down arrow.
Regression range
- Reproducible with Firefox 62.0a1(20180509220105). I will search for one ASAP if there is one.
Additional Notes
- Attached a screenshot with the issue.
- The issue reproduces only in Customize Menu.
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
What platform and Firefox version is the screenshot taken on? There's also a gap between the arrow and the overflow panel itself, which I thought we fixed recently.
Reporter | ||
Comment 2•5 years ago
|
||
Sorry I didn't notice that. The screenshot is taken on 70.0.1 (20191030021342) using Windows 10x64. Also adding a screenshot from the latest Nightly (20191112094307) and 71.0b9(20191111170815). It seems that there is no gap here.
Assignee | ||
Comment 3•5 years ago
|
||
(In reply to Alexandru Trif, QA [:atrif] from comment #2)
Created attachment 9108102 [details]
overflow_002.pngSorry I didn't notice that. The screenshot is taken on 70.0.1 (20191030021342) using Windows 10x64. Also adding a screenshot from the latest Nightly (20191112094307) and 71.0b9(20191111170815). It seems that there is no gap here.
OK, great. Then yeah, it'd be helpful to have a regression window here for the original issue. Note that the horizontal offset here has been broken and fixed at least once before so it may be tricky to figure out when it last broke...
Comment 4•5 years ago
|
||
Bugbug thinks this bug is a regression, but please revert this change in case of error.
Assignee | ||
Comment 5•5 years ago
|
||
bug 1398103 changed the inner/outer padding on toolbar buttons and seems to have broken this.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 6•5 years ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/74da59be7123 make overflow panel arrow position in customize mode more reliably correct, r=dao
Updated•5 years ago
|
Comment 8•5 years ago
|
||
bugherder |
Reporter | ||
Comment 9•5 years ago
|
||
Hello!
Verified the issue using Firefox 72.0a1 (20191118093852) on Windows 10x64, macOS 10.15 and Ubuntu 18.04. The arrow from the overflow menu is correctly updated when changing the density settings in the Customize Menu.
Updated•5 years ago
|
Updated•2 years ago
|
Description
•