Closed Bug 1595823 Opened 3 months ago Closed 2 months ago

Fix the AudioContext's sample-rate if privacy.resistFingerprinting is enabled

Categories

(Core :: Web Audio, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: padenot, Assigned: padenot)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fingerprinting])

Attachments

(1 file)

Before doing this (the patch is rather simple), I need to make sure this does not leak through enumerateDevice or something like this.

This might have performance implications on Android, as the audio output low-latency path only works with the primary sample-rate of the device. I'll investigate this as well.

44100 or 48000 are both the most common rate (on various OS/hw configuration), I think picking 44100 is good enough on desktop.

On mobile, sometimes 48000 instead of 44100 will bring a nice perf boost, and is super common enough to pick.

Priority: -- → P3

jib, would you have info about the first sentence? What does change for enumerateDevices if RFP is enabled? Can we find the system default device using one of those mediaDevices methods?

Flags: needinfo?(jib)
Flags: needinfo?(jib)
Summary: Fix the AudioContext's sample-rate if RFP is enabled → Fix the AudioContext's sample-rate if privacy.resistFingerprinting is enabled

enumerateDevices already lies when privacy.resistFingerprinting is enabled (bug 1372073), returning dummy devices.

Additionally, we don't expose capabilities yet anyway through enumerateDevices (bug 1179084), so we're good there.

We don't expose sampleRate yet in track.getSettings() because we don't implement the sampleRate constraint yet bug 1388586.

I'll add notes in the open bugs to remember to respect the privacy.resistFingerprinting pref.

If the sample-rate is 44100 or 48000, use that, it's common enough (roughly
49.5% each). Else, use 48000.

Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c5dbc172388f
Fix the AudioContext's sample-rate if privacy.resistFingerprinting is enabled. r=tjr
Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/c57ebfe0e074
Fix the AudioContext's sample-rate if privacy.resistFingerprinting is enabled. r=tjr
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Assignee: nobody → padenot
You need to log in before you can comment on or make changes to this bug.