1595825 - wasmTextToBinary: allow br and br_if and br_table to pass multiple values

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P3)

Description

[Lars T Hansen [:lth]]

I believe this should parse, but does not because the parsers for the branch instructions have limitations on how many value arguments they can take:

  (module
    (func (result i32)
      (block (result i32 i32)
        (br 0 (i32.const 1) (i32.const 2)))
      (drop)))

Comment 1

[Lars T Hansen [:lth]]

Attachment: Bug 1595825 - Text-to-binary branch instructions with multiple values. r?wingo

Allow br, br_if, and br_table to pass multiple results to their target
blocks. This turned out to be easy: there was what appeared to be
arbitrary complexity in handling both br_if and br_table, this is now
removed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71bcb50a0a8c
Text-to-binary branch instructions with multiple values. r=wingo

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/71bcb50a0a8c