Closed Bug 1595825 Opened 1 year ago Closed 11 months ago

wasmTextToBinary: allow br and br_if and br_table to pass multiple values

Categories

(Core :: Javascript: WebAssembly, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: lth, Assigned: lth)

References

Details

Attachments

(1 file)

I believe this should parse, but does not because the parsers for the branch instructions have limitations on how many value arguments they can take:

  (module
    (func (result i32)
      (block (result i32 i32)
        (br 0 (i32.const 1) (i32.const 2)))
      (drop)))
Priority: -- → P3

Allow br, br_if, and br_table to pass multiple results to their target
blocks. This turned out to be easy: there was what appeared to be
arbitrary complexity in handling both br_if and br_table, this is now
removed.

Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/71bcb50a0a8c
Text-to-binary branch instructions with multiple values. r=wingo
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.