1595869 - Add model version number to all pings for personalized CFR experiment

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Kate Hudson :k88hudson]

In order to determine which model version is applied to each CFR, we'd like to capture the model version number in telemetry.

We should consider the message object the source of truth (i.e. attach the model version to it) to prevent possible background syncing from causing inconsistencies.

Comment 1

[Nan Jiang [:nanj]]

Attachment: Bug 1595869 - Add model version id to all pings for personalized CFR experiment

Comment 2

[Nan Jiang [:nanj]]

Attachment: data_review_request_cfr_model_version.txt

Hey Martin,

Could you do a data review for this patch, please? You can find the detailed document here.

Thanks!

Comment 3

[mlopatka]

Comment on attachment 9112305 [details]
data_review_request_cfr_model_version.txt

Hello :nanj, Please update the data review form with a few more details for transparency.

1- Please provide a link to the experiment bug for transparency
2- Please provide a worst case scenario estimate of the experiment (and data collection) duration in your response to question 6. I can recommend a 6 month window to provide some flexibility for removal of the probe. Also, as a temporary collection measure it is helpful if a bug is filed and referenced for the removal of this measurement.

Comment 4

[Nan Jiang [:nanj]]

Attachment: data_review_request_cfr_model_version.txt

Thanks, Martin!

The review form has been updated accordingly.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d51b93be3e16
Add model version id to all pings for personalized CFR experiment r=k88hudson

Comment 6

[mlopatka]

Comment on attachment 9112425 [details]
data_review_request_cfr_model_version.txt

looks good. Data review r+

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/d51b93be3e16