Restore handling of selectedIndex return value of sendSyncMessage
Categories
(Toolkit :: Autocomplete, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: enndeakin, Assigned: enndeakin)
References
Details
Attachments
(1 file)
The return value of sendSyncMessage is an array. Code to handle this for the FormAutoComplete:GetSelectedIndex was incorrectly removed by 1573836.
This causes the error: Console message: [JavaScript Error: "NS_ERROR_ILLEGAL_VALUE: Index out of range." {file: "resource://formautofill/ProfileAutoCompleteResult.jsm" line: 105}]
|
Assignee | |
Comment 1•5 years ago
|
||
Note that as far as I can tell, this error doesn't cause any issues, and only -- I think -- fails for value of -1, when there isn't something selected anyway.
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Comment 3•5 years ago
|
||
(In reply to Neil Deakin from comment #0)
The return value of sendSyncMessage is an array. Code to handle this for the FormAutoComplete:GetSelectedIndex was incorrectly removed by 1573836.
For reference it was https://hg.mozilla.org/mozilla-central/rev/25ba54160c0aee63142e87bf06e67b92c89f566a#l4.18
|
||
Updated•5 years ago
|
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3073a3b8530c fix handling of return value of FormAutoComplete:GetSelectedIndex that was incorrectly removed by 1573836, r=MattN
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Description
•