Closed Bug 1595875 Opened 1 year ago Closed 1 year ago

Restore handling of selectedIndex return value of sendSyncMessage

Categories

(Toolkit :: Autocomplete, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: enndeakin, Assigned: enndeakin)

References

Details

Attachments

(1 file)

The return value of sendSyncMessage is an array. Code to handle this for the FormAutoComplete:GetSelectedIndex was incorrectly removed by 1573836.

This causes the error: Console message: [JavaScript Error: "NS_ERROR_ILLEGAL_VALUE: Index out of range." {file: "resource://formautofill/ProfileAutoCompleteResult.jsm" line: 105}]

Blocks: 1573836

Note that as far as I can tell, this error doesn't cause any issues, and only -- I think -- fails for value of -1, when there isn't something selected anyway.

(In reply to Neil Deakin from comment #0)

The return value of sendSyncMessage is an array. Code to handle this for the FormAutoComplete:GetSelectedIndex was incorrectly removed by 1573836.

For reference it was https://hg.mozilla.org/mozilla-central/rev/25ba54160c0aee63142e87bf06e67b92c89f566a#l4.18

Priority: -- → P1
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3073a3b8530c
fix handling of return value of FormAutoComplete:GetSelectedIndex that was incorrectly removed by 1573836, r=MattN
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.