1595905 - OurStickys add-on no longer allows editing notes besides the last line

Status: VERIFIED INVALID

(Core :: CSS Parsing and Computation, defect)

Description

[Asif Youssuff]

From: https://www.reddit.com/r/firefox/comments/dsh6ip/looking_for_extensions_that_let_you_put_sticky/

Steps to reproduce:

1. Install https://addons.mozilla.org/en-US/firefox/addon/ourstickys/
2. Go to any web page.
3. Right click on page, select "add sticky"
4. Paste text like:

CANNOT BE EDITED, NAVIGATED TO, HIGHLIGHTED OR COPIED (1)

CANNOT BE EDITED, NAVIGATED TO, HIGHLIGHTED OR COPIED (2)

CANNOT BE EDITED, NAVIGATED TO, HIGHLIGHTED OR COPIED (3)

CAN BE EDITED NORMALLY

5. Select or try to edit lines containing CANNOT BE EDITED, NAVIGATED TO, HIGHLIGHTED OR COPIED (1, 2, or 3)

What happens:

Cursor jumps to last line, all lines except last line can be edited.

Expected result:

The entire note should be editable.

14:47.36 INFO: Narrowed inbound regression window from [7b90628f, 678d5b05] (3 builds) to [7b90628f, d806a12c] (2 builds) (~1 steps left)
14:47.36 INFO: No more inbound revisions, bisection finished.
14:47.36 INFO: Last good revision: 7b90628fa1e7f153e574c07626b6af5378593a45
14:47.36 INFO: First bad revision: d806a12ca46833286baf4c2f320db7d667a28883
14:47.36 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7b90628fa1e7f153e574c07626b6af5378593a45&tochange=d806a12ca46833286baf4c2f320db7d667a28883

Comment 1

[Asif Youssuff]

FYI, unfortunately, the developer of this add-on has passed away, so if the add-on needs a fix, it'd be great if Mozilla or someone could step up to fix the add-on and update it in place (it is BSD licensed). https://www.legacy.com/obituaries/name/fabrizio-parrella-obituary?pid=188112546

Comment 2

[Daniel Holbert [:dholbert]]

So this "regressed" due to us adding support for the user-select CSS property.

And indeed, the extension does use that property. Downloading its XPI and unzipping it, I see:

$ grep -r "user-select" *
css/notes.css:	user-select: none;
css/notes.css:	user-select: text !important;
css/notes.css:	user-select:text !important;
popup/popup.css:	user-select: none;

This CSS had zero effect in Firefox before that pushlog, and started having an effect after that pushlog (when we added support for unprefixed user-select. The first or last line there are the relevant lines that would introduce the reported behavior -- user-select:none does indeed cause the element to not be selectable, as discussed at https://developer.mozilla.org/en-US/docs/Web/CSS/user-select .

If someone wants to fix this issue, and restore the pre-bug 1492739 behavior, they would need to simply remove those lines of CSS. (The first and last ones in particular, but perhaps all four since, again, they had zero effect in Firefox before bug 1492739 landed.)

it'd be great if Mozilla or someone could step up to fix the add-on and update it in place

This would indeed be great, but given limited developer resources and the small user-base of this add-on, I doubt this would be a high-priority item. This sounds like a task for some committed user of the add-on, perhaps?

Also, the Firefox core bug-tracker is not really the place to organize that work, either (we use this for tracking changes to Firefox itself), so I'm closing this as INVALID since the reported behavior is correct per-spec and there aren't any changes that we're planning on making to the Firefox codebase here.

Comment 3

[Asif Youssuff]

FYI for anyone interested - I uploaded a fixed version here: https://addons.mozilla.org/firefox/addon/ourstickys-sticky-notes/

Thanks for your help, Daniel!

Comment 4

[Daniel Holbert [:dholbert]]

Great, thanks yoasif!