1596137 - mozAddonManager.reportAbuse should reject on unsupported addon types

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

Currently mozAddonManager.reportAbuse is resolving to false when called for an addon type which isn't yet supported by the integrated abuse report panel.

We should instead reject explicitly to make AMO able to detect when the report failed to be created instead of being cancelled by the user, so that they can fallback on the report form integrated on the AMO website.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1596137 - mozAddonManager.reportAbuse should reject on unsupported addon types. r?mixedpuppy!

mozAddonManager.reportAbuse should reject explicitly when called for an unsupported addon type,
to make AMO able to detect when if triggering the integrated report failed instead of being cancelled by the user,
and fallback on the report form integrated on the AMO website.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7405a856572c
mozAddonManager.reportAbuse should reject on unsupported addon types. r=mixedpuppy

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/7405a856572c

Comment 4

[vcarciu]

Verified as fixed in FF 72.0a1 (2019-11-15).

I will attach a postfix screenshot.

Comment 5

[vcarciu]

Attachment: Postfix Screenshot