1596164 - navigator.geolocation.getCurrentPosition success callback not called when maximumAge option is specified

Status: RESOLVED FIXED

(GeckoView :: General, defect, P2)

Description

[Ksenia Berezina [:ksenia]]

As reported here https://github.com/webcompat/web-bugs/issues/43954

STR:

1. Visit https://www.playnow.com/login/ in Firefox Fenix/ Fenix Nightly
2. Enter login and password (can be anything)
3. Click "Log in now" button
4. Click "Allow" in the geolocation permission prompt

Expected behavior:
Form submit is happening and error message displayed: "Sorry, your login information did not match our records..."
Actual:
Form submit is not performed and submit button becomes disabled

A reduced test case:
https://codepen.io/ksy36/pen/NWWOKgJ

This seems to be caused by maximumAge specified in the options (maximumAge: 10000). If I remove it, the success callback is fired.

Comment 1

[Mike Taylor [:miketaylr]]

I get expected behavior in Firefox for Android, but not in Fenix Preview. Is this a GeckoView bug?

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Seems like it. Adding to triage.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:garvan, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Chris Peterson [:cpeterson]]

Since we're fixing some other geolocation bugs, we should retest this bug.

Comment 5

[Makoto Kato [:m_kato]]

When reporting current location by here, doesn't SendLocation send it?

Actually, GV uses that nsGeoPosition's timestamp is older than PR_Now(). But other platform uses PR_Now() now, so can we fix it by using same way?

Comment 6

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/jobs?repo=try&revision=b4dd0432ddbba3d5bde261ca4ae0b48f85ccfa3c

Comment 7

[Makoto Kato [:m_kato]]

Attachment: Bug 1596164 - Use PR_Now instead of location service's acquired time. r=#geckoview-reviewers

android.location.Location.getTime() will return the acquired location time
that depends on location service. But maximumAge will be calculated by
current time (PR_Now()). So if the acquired time is old time,
nsGeolocationRequest::SendLocation won't send the location due to too old
(isTooOld=true in nsGeolocationRequest::SendLocation).

Like other platforms, we should pass PR_Now as the location time instead.

Also, GVE sometimes hits debug assertion since heading and/or speed aren't
expected value, so this patch fixes this situation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/295e95d1ce00
Use PR_Now instead of location service's acquired time. r=geckoview-reviewers,agi

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/295e95d1ce00

Comment 10

[Chris Peterson [:cpeterson]]

This is an old bug, so there's no rush to uplift this fix to Beta 102. The fix can ride the trains with 103.