Closed Bug 1596283 Opened 5 years ago Closed 4 years ago

clang doesn't produce code deterministically in nsMediaFragmentURIParser::ParseNPTFraction

Categories

(Firefox Build System :: Toolchains, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: glandium, Unassigned)

References

(Blocks 1 open bug)

Details

In 2 builds out of the 6 retriggers I did with the patch from bug 1577212 applied, the condition if (index > 1) in nsMediaFragmentURIParser::ParseNPTFraction was compiled as

95e075:​»       ​83·​fb·​02·​·​·​·​·​·​·​·​·​·​·​·​·​»       ​cmp·​·​·​·​$0x2,​%ebx
95e078:​»       ​73·​80·​·​·​·​·​·​·​·​·​·​·​·​·​·​·​·​»       ​jae·​·​·​·​95dffa·​<mozilla:​:​net:​:​nsMediaFragmentURIPar​ser:​:​ParseNPTFraction(nsTD​ependentSubstring<cha​r16_t>&,​·​double&)​+0x7a>

while it's usually compiled as

95e075:​»       ​83·​fb·​01·​·​·​·​·​·​·​·​·​·​·​·​·​»       ​cmp·​·​·​·​$0x1,​%ebx​
95e078:​»       ​77·​80·​·​·​·​·​·​·​·​·​·​·​·​·​·​·​·​»       ​ja·​·​·​·​·​95dffa·​<mozilla:​:​net:​:​nsMediaFragmentURIPar​ser:​:​ParseNPTFraction(nsTD​ependentSubstring<cha​r16_t>&,​·​double&)​+0x7a>
Blocks: 1577212

This seems to be a regression between clang 8.0 and 9.0. Why? Because I can reproduce the same issue with FF70 with clang 9.0, while it didn't happen with clang 8.0.

It seems like this is not happening anymore.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.