1596310 - ASSERTION: unexpected max block size: 'aBSize >= 0'

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Mats Palmgren (inactive)]

Attachment: Testcase

STR

1. load the attached testcase in a DEBUG build
2. open Print Preview

ACTUAL RESULTS

###!!! ASSERTION: unexpected max block size: 'aBSize >= 0', file layout/generic/nsFloatManager.cpp, line 110
###!!! ASSERTION: illegal height for combined area: 'aOverflowAreas.Overflow(otype).height >= 0', file layout/generic/nsLineBox.cpp, line 535
###!!! ASSERTION: illegal height for combined area: 'aOverflowAreas.Overflow(otype).height >= 0', file layout/generic/nsLineBox.cpp, line 535

Comment 1

[Mats Palmgren (inactive)]

Attachment: Bug 1596310 - Clamp negative available size to zero and ensure page break frames don't apply margins. r=TYLin

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

FWIW, I cannot reproduce this bug with the testcase attached in comment 0, but I can with the crashtest in the patch. Instead of STR step 2, using "Toggle -> Paged Mode" in the layout debugger can trigger the assertions as well.

Comment 3

[Mats Palmgren (inactive)]

That's odd. It does reproduce it for me on Linux using a fresh profile. That test uses 100vh though which I realized is quite buggy in any paginated mode (see my comments in bug 1414600). So I switched to using 100% instead for the tests in the patch since it appears more reliable. (I also have a couple of tests for bug 471015 that trigger the assertion without this patch, fwiw).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1d9e657897e
Clamp negative available size to zero and ensure page break frames don't apply margins.  r=TYLin

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c1d9e657897e