Mirror custom json schema validation for extra_options
Categories
(Taskcluster :: General, task, P2)
Tracking
(Not tracked)
People
(Reporter: igoldan, Unassigned)
References
Details
The custom json schema validation from this Github PR, written in Python, needs to be mirrored on mozilla-central. This ticket ensures bug 1572516 is entirely & properly done.
I don't say this is the best approach (I'm definitely not a fan of copy/pasting source code from one place to another), but we need this validation mechanic to be available there as well, for early erroring. It allows developers to quickly see if their data producers are working as expected.
In time, we need to find a way to properly share the performance-artifact.json schema (+ plus any other extra validation) between Perfherder and mozilla-central. Either export this validation in a web microservice or a custom third party package etc
|
Reporter | |
Comment 1•5 years ago
|
||
(In reply to Ionuț Goldan [:igoldan], Performance Sheriff from comment #0)
In time, we need to find a way to properly share the performance-artifact.json schema (+ plus any other extra validation) between Perfherder and
mozilla-central. Either export this validation in a web microservice or a custom third party package etc
Armen, Cameron do you have any opinions/suggestions on this?
|
||
Comment 2•5 years ago
|
||
Do we do the validation on the task and turn the job orange if it fails? If do it there there's no need to do it again on Treeherder.
Also notice that all of these validations will get on the way of re-running past tasks because past tasks will not conform to the new schema (assuming they're not optional changes).
|
||
Comment 3•5 years ago
|
||
Yeah, I struggled with a similar issue once before. I never came up with a better solution than keeping two copies. There were VERY rarely changes, so it ended up being fairly ok.
I like the 3rd party package idea. That makes good sense.
Description
•