Closed
Bug 1596366
Opened 6 years ago
Closed 6 years ago
Clean up selectors after bug 1492582
Categories
(Firefox :: Theme, task, P1)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Comment 2•6 years ago
|
||
This change seems fine, but what's the reasoning behind it ? Were descendant selectors more performant only for XUL but not HTML roots or something similar ? Just asking so this can be documented for future CSS patches.
Flags: needinfo?(dao+bmo)
|
|
||
Updated•6 years ago
|
|
|
Assignee | |
Comment 3•6 years ago
|
||
(In reply to Tim Nguyen :ntim from comment #2)
This change seems fine, but what's the reasoning behind it ? Were descendant selectors more performant only for XUL but not HTML roots or something similar ? Just asking so this can be documented for future CSS patches.
I'm not sure what you're asking. Before bug 1492582, these rules were using only the child selector. Now they use a combination of the descendant selector and some dangling child selectors, the latter being entirely redundant.
|
|
Assignee | |
Updated•6 years ago
|
Priority: -- → P1
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/65e4b8d04024
Clean up selectors after bug 1492582. r=Gijs
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in
before you can comment on or make changes to this bug.
Description
•