Closed Bug 1596366 Opened 29 days ago Closed 27 days ago

Clean up selectors after bug 1492582

Categories

(Firefox :: Theme, task, P1)

task

Tracking

()

RESOLVED FIXED
Firefox 72
Tracking Status
firefox72 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

No description provided.

This change seems fine, but what's the reasoning behind it ? Were descendant selectors more performant only for XUL but not HTML roots or something similar ? Just asking so this can be documented for future CSS patches.

Flags: needinfo?(dao+bmo)
No longer blocks: 1492582
Depends on: 1492582

(In reply to Tim Nguyen :ntim from comment #2)

This change seems fine, but what's the reasoning behind it ? Were descendant selectors more performant only for XUL but not HTML roots or something similar ? Just asking so this can be documented for future CSS patches.

I'm not sure what you're asking. Before bug 1492582, these rules were using only the child selector. Now they use a combination of the descendant selector and some dangling child selectors, the latter being entirely redundant.

Blocks: 1492582
No longer depends on: 1492582
Flags: needinfo?(dao+bmo)
Priority: -- → P1
Status: ASSIGNED → RESOLVED
Closed: 27 days ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in before you can comment on or make changes to this bug.