1596367 - Turn off testing and performance sherffinig on mozilla-inbound

Status: RESOLVED FIXED

(Testing :: Raptor, task, P1)

Description

[Florin Strugariu [:Bebe]]

As of 14-Nov-2019 we should not run perf tests on Mozilla-Inbound see: Bug 1530401

Remove all explicitly mentioned task settings from raptor and Thalos CI settings.
Check and confirm the phabricator settings in mozilla-inbound alerts

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

assuming we stop all builds/tests, we would change taskcluster to make 'trunk' == 'mozilla-central, autoland'

We also should fix Treeherder to not generate alerts on mozilla-inbound- it won't necessarily matter, but it would be good to clean up things

Comment 2

[Alexandru Ionescu (needinfo me) [:alexandrui]]

On it

Comment 3

[Alexandru Ionescu (needinfo me) [:alexandrui]]

:igoldan, do you think I can handle deactivating inbound alerts on treeherder ?

Comment 4

[Alexandru Ionescu (needinfo me) [:alexandrui]]

:jmaher, there is taskcluster/taskgraph/test/test_target_tasks.py and taskcluster/taskgraph/test/test_util_attributes.py that also contains mozilla-inbound. The first one seems like needs to be updated as well, but I'm not sure about the second.
Could you please advise?

Comment 5

[Ionuț Goldan [:igoldan]]

(In reply to Alexandru Ionescu :alexandrui from comment #3)

:igoldan, do you think I can handle deactivating inbound alerts on treeherder ?

Indeed, Treeherder does require some tweaks. There's this repository.json fixture which needs to disable alerting for mozilla-inbound.

Still, once that lands, the database won't reflect that. You'll then need to ask the Treeherder team to set the performance_alert_enabled column to 0, for the mozilla-inbound repository, on the repository table. They'll just need to prepare a raw SQL script & run it against treeherder-prototype, treeherder-staging & treeherder-production.

I think there will be other changes required too, but please require my review when submitting the PR.

Comment 6

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Ionuț Goldan [:igoldan], Performance Sheriff from comment #5)

Still, once that lands, the database won't reflect that. You'll then need to ask the Treeherder team to set the performance_alert_enabled column to 0, for the mozilla-inbound repository, on the repository table. They'll just need to prepare a raw SQL script & run it against treeherder-prototype, treeherder-staging & treeherder-production.

Can you help me with this part as soon as you approve the PR for repository.json?

Comment 7

[Ionuț Goldan [:igoldan]]

Yes, I will.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Ideally when specifying 'integration' or 'trunk' it wouldn't use mozilla-inbound, this would apply to all jobs though, not just perf test, or even unit test.

Right now I think the best way is to wait until all tests are disabled, but it could be done in the raptor.yml:
https://searchfox.org/mozilla-central/source/taskcluster/ci/test/raptor.yml

here you would change:

• trunk -> 'mozilla-central', 'autoland'
• integration -> 'autoland'

Comment 9

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Not sure what do you mean by 'wait until all the tests are disabled'. Is there any bug like that open?

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

ok, I found Bug 1530401

Comment 11

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Attachment: Bug 1596367 Turn off testing and performance sherffinig on mozilla-inbound

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5d38101ac7c
Turn off testing and performance sherffinig on mozilla-inbound r=jmaher

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f5d38101ac7c