Closed
Bug 1596511
Opened 5 years ago
Closed 5 years ago
Remove GetBindingParent usage in SVG code.
Categories
(Core :: DOM: Core & HTML, defect, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(2 files)
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
It looked a bit weird after the XBL removal. Can be simpler and not use
GetBindingParent.
|
|
Assignee | |
Comment 2•5 years ago
|
||
This doesn't need to handle NAC anymore since <svg:use> element doesn't use NAC
anymore.
Handle Shadow DOM by using GetParentOrShadowHostNode(), though we should figure
out what the right thing to do since GetOwnerSVGElement and co. use
GetFlattenedTreeParent().
In practice, these should be equivalent because SVG Elements can't be shadow
hosts.
Depends on D53062
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fc12d7dbaaf5 Simplify SVGObserverUtils::GetBaseURLForLocalRef. r=smaug https://hg.mozilla.org/integration/autoland/rev/94cd78feaa1f Remove binding parent usage from SVGSVGElement. r=smaug
Priority: -- → P3
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fc12d7dbaaf5
https://hg.mozilla.org/mozilla-central/rev/94cd78feaa1f
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
|
||
Updated•5 years ago
|
Assignee: nobody → emilio
You need to log in
before you can comment on or make changes to this bug.
Description
•