Thanks for the quick turn-around.
The next steps should be owned by the Localization PM in charge of the product. I'll double check with Jeff later this week, but I assume it'll still be Peiying.
Thank you for the reviews and the information. I believe I've addressed all issues except for the concatenations, which I'll be starting on shortly. After those are fixed, are we safe to enable things in Pontoon?
We still have to figure out the fr-CA issue. I don't think it makes sense to enable that language in Pontoon, but that's both a product and PM decision.
I think you still need to add Pontoon's bot to the repository with write access? I believe Matjaz will need to accept the invitation, since it's not in the mozilla organization.
Pontoon's bot: https://github.com/mozilla-pontoon
- The project needs to be added to Pontoon stage to test that sync works. We could do that even before fixing the current issues.
- If everything works, it just needs to be added to production. We will also need to send out information to localizers about the new project.
- We should set up automatic review via CODEOWNERS for changes to the en-US FTL files. The PM needs to be added as contributor to the project (example).
I have 2 new translation PRs that were opened this weekend. Do you suggest I hold off on merging those until after Pontoon is enabled? Will the authors need to then input into Pontoon instead, or is there a way to easily import from GitHub?
At this point you should merge them before Pontoon is enabled, so they get picked up. It should also important to figure out a way to avoid folks opening PRs for that in the future, not sure I have suggestions sadly.
One other question: do comments need to be carried over to each translation, or do they only need to exist in the primary source?
No, Pontoon will carry them over from the source file. When you add new strings, you only add them to en-US, and Pontoon will write them (with comments) when there's a new translation available.
One thing that you should consider: the history will get noisy (example). Some projects don't want that, and make Pontoon commit in a branch. That means that updates on trunk are not exposed immediately for translation, and that developers need to manually merge the branch to master (back and forward).