1596542 - Only run browsingData API "test_browserData_should_not_remove_extension_data" test case if LSNG is enabled

Status: RESOLVED FIXED

(WebExtensions :: Storage, task)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

Bug 1575891 uplift to beta has been backed out because of a failure triggered by this test when LSNG is not enabled.

To avoid the test to fail again if we have to disable LSNG also in Firefox 72 (which should be unlikely, but still better if we can make it simpler in case we have to) we should at least skip this particular test case when LSNG is turned off explicitly.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1596542 - Skip test_browserData_should_not_remove_extension_data if LSNG is disabled. r?mixedpuppy!

When LSNG is disabled, the browsingData API does clear the localStorage data by notify a "extension:purge-localStorage"
message over the observer service, when the browserData API call doesn't specify a list of specific origins to clear,
the code that handles "extension:purge-localStorage" will clear all the localStorage data, including the one stored by extensions:

• https://searchfox.org/mozilla-central/rev/e7c61f4a68b974d5fecd216dc7407b631a24eb8f/browser/components/extensions/parent/ext-browsingData.js#172
• https://searchfox.org/mozilla-central/rev/e7c61f4a68b974d5fecd216dc7407b631a24eb8f/dom/storage/StorageObserver.cpp#292-295,323,326

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d79432359063
Skip test_browserData_should_not_remove_extension_data if LSNG is disabled. r=mixedpuppy

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d79432359063

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Set qe-verify-, as this is a test-only change.