1596546 - disable cubeb lazy dlopening on OpenBSD to fix sound when sandboxed

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P3)

Description

[Landry Breuil (:gaston)]

Since bug #1580271 the firefox process only sees the files we unveil to it, which doesnt include libsndio, which is used to play sound via cubeb sndio backend.

In bug #1575883, cubeb was updated to contain https://github.com/kinetiknz/cubeb/pull/539 which lazily dlopen() libsndio when needed (ie at the first sound played) - of course this doesnt go well with the unveil work, thus the sound is broken, as reported on https://marc.info/?l=openbsd-ports&m=157339003330019&w=2.

Technically, on OpenBSD we know that sndio is the sound backend we use, so we can disable the sndio dlopening and directly link with sndio as it was the case before.

All that to say i'm going to put https://cgit.rhaalovely.net/mozilla-firefox/commit/?h=unveil&id=ed3d4671090ec2449cb9ab935a923862275f43d6 for review :)

Comment 1

[Landry Breuil (:gaston)]

Attachment: Bug 1596546: disable sndio lazy loading on OpenBSD, and directly link with it r?kinetik

unveil() work in bug #1580271 broke sound playback

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58992c594ec7
disable sndio lazy loading on OpenBSD, and directly link with it r=kinetik

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/58992c594ec7

Comment 4

[Jan Beich]

Does building cubeb tests as part of Firefox still work? (Remove --disable-tests from your .mozconfig.) For one, bug 1588669 also removed OpenBSD conditional from media/libcubeb/gtest/moz.build.

Comment 5

[Landry Breuil (:gaston)]

i dont have --disable-tests, so dunno if the tests are built or not by default...