1596549 - moz-phab 0.1.60 fails with older versions of git with errors about --list-cmds=main,others

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P1)

Description

[Nathan Froyd [:froydnj]]

froydnj@hawkeye:~/src/gecko$ moz-phab submit --bug 1596547 6c76395^ 6c76395
Upgrading to version 0.1.60
Collecting MozPhab
  Downloading https://files.pythonhosted.org/packages/d5/7c/df3484a2cb527d07abf608f00d63b2162d427fd59ea56c44610b0a3be1a6/MozPhab-0.1.60.tar.gz (53kB)
    100% |████████████████████████████████| 61kB 1.7MB/s 
[?25hCollecting setuptools (from MozPhab)
  Downloading https://files.pythonhosted.org/packages/d9/de/554b6310ac87c5b921bc45634b07b11394fe63bc4cb5176f5240addf18ab/setuptools-41.6.0-py2.py3-none-any.whl (582kB)
    100% |████████████████████████████████| 583kB 35.4MB/s 
[?25hInstalling collected packages: setuptools, MozPhab
  Running setup.py install for MozPhab ... [?25ldone
[?25hSuccessfully installed MozPhab-0.1.59 setuptools-41.5.1
Restarting...
Unknown option: --list-cmds=main,others
usage: git [--version] [--help] [-C <path>] [-c name=value]
           [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]
           [-p | --paginate | --no-pager] [--no-replace-objects] [--bare]
           [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]
           <command> [<args>]
CommandError: command 'git' failed to complete successfully
CommandError: command '/usr/bin/python3' failed to complete successfully
froydnj@hawkeye:~/src/gecko$ git --version
git version 2.7.4

Comment 1

[Nathan Froyd [:froydnj]]

git help -a seems to display all available commands, albeit not in the same form that I think --list-cmds does.

Comment 2

[:glob ✱]

git version 2.18 introduced the --list-cmds command.

Prior to that the bash completion script parsed the output of git help -a, so we should do the same.

Comment 3

[:glob ✱]

Attachment: Bug 1596549 - moz-phab fails on version of git older than 2.18; r=zalun

Comment 4

[Piotr Zalewa [:zalun]]

https://github.com/mozilla-conduit/review/commit/6d91bd3ce8e0f5e009e89caf0e683606b661c1e7

Released in 0.1.61