Open Bug 1596586 Opened 1 year ago Updated 10 months ago

ubuntu1804 - refactor pulseaudio initialization

Categories

(Firefox Build System :: Task Configuration, enhancement)

Product:
Firefox Build System
Component:
Task Configuration
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
ASSIGNED

People

(Reporter: egao, Assigned: egao)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1596586 - rename start_pulseaudio to load_pulseaudio_module
47 bytes, text/x-phabricator-request
Details | Review

Currently, the start-pulseaudio step is in the base harness that is run by all test instances, not just Linux:

https://searchfox.org/mozilla-central/source/testing/mozharness/scripts/desktop_unittest.py#613-635

This should be considered a kludge as platform-specific items should not be located in a harness script run by all platforms.

Once debian10 works stabilizes, investigate if possible to move this step to a Linux specific piece of code.

Summary: debian 10 - refactor pulseaudio initialization → refactor pulseaudio initialization
Duplicate of this bug: 1580361
Summary: refactor pulseaudio initialization → ubuntu1804 - refactor pulseaudio initialization
Attachment #9136195 - Attachment description: Bug 1596586 - refactor pulseaudio initialiation for docker-worker → Bug 1596586 - refactor pulseaudio initialization for docker-worker
Assignee: nobody → egao
Status: NEW → ASSIGNED
Attachment #9136195 - Attachment is obsolete: true

Changes:

  • move mozharness call to load the module-null-sink to the base class.
  • rename method to better reflect the intended action.
Attachment #9157363 - Attachment description: Bug 1596586 - rename start_pulseaudio to load_pulseaudio_module and move into base mozharness class → Bug 1596586 - rename start_pulseaudio to load_pulseaudio_module
You need to log in before you can comment on or make changes to this bug.