1596630 - Remove mSyncObject->Synchronize() in RenderCompositorANGLE::BeginFrame()

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

It seems that current WebRender seems not need mSyncObject->Synchronize() anymore.

For now, d3d texture is used only for video, WebGL and plugin. In those cases, we try to use keyed mutex for synchronization.

Comment 1

[Sotaro Ikeda [:sotaro]]

Followings does not handle keyed mutex

• [1] canvas 2d
• [2] D3D11DXVA2Manager

D3D11DXVA2Manager's case, SyncObjectD3D11Client::Synchronize() is called in D3D11DXVA2Manager::CopyToImage(), then texture data copy should be already completed in the CopyToImage(). Then it is not related to the Synchronize() call in RenderCompositorANGLE::BeginFrame().

Comment 2

[Sotaro Ikeda [:sotaro]]

Bug 1340398 seem added SyncObject usage to D3D11DXVA2Manager.

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1596630 - Remove mSyncObject->Synchronize() in RenderCompositorANGLE::BeginFrame()

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0dfc557b20c
Remove mSyncObject->Synchronize() in RenderCompositorANGLE::BeginFrame() r=nical

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f0dfc557b20c