Closed Bug 1596630 Opened 5 months ago Closed 5 months ago

Remove mSyncObject->Synchronize() in RenderCompositorANGLE::BeginFrame()

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file)

It seems that current WebRender seems not need mSyncObject->Synchronize() anymore.

For now, d3d texture is used only for video, WebGL and plugin. In those cases, we try to use keyed mutex for synchronization.

Assignee: nobody → sotaro.ikeda.g

Followings does not handle keyed mutex

  • [1] canvas 2d
  • [2] D3D11DXVA2Manager

D3D11DXVA2Manager's case, SyncObjectD3D11Client::Synchronize() is called in D3D11DXVA2Manager::CopyToImage(), then texture data copy should be already completed in the CopyToImage(). Then it is not related to the Synchronize() call in RenderCompositorANGLE::BeginFrame().

Bug 1340398 seem added SyncObject usage to D3D11DXVA2Manager.

Pushed by sikeda.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f0dfc557b20c
Remove mSyncObject->Synchronize() in RenderCompositorANGLE::BeginFrame() r=nical
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Regressions: 1612665
You need to log in before you can comment on or make changes to this bug.