1596663 - Switch to async login search APIs to support GeckoView storage queries

Status: RESOLVED FIXED

(Toolkit :: Password Manager, task, P1)

Description

[Matthew N. [:MattN]]

Most nsILoginManagerStorage APIs are synchronous (except for initialize, terminate, & getAllLoginsAsync) for legacy reasons but we need to switch the APIs used for capture/fill (not management) to be async to support async queries to GeckoView.

searchLogins is the main issue, maybe findLogins if the one consumer can't switch to the async searchLogins API.

We will need to keep the sync APIs for Thunderbird so the storage-json.js backend for desktop apps can simply delegate from the async to the sync API to preserve compatibility. The GeckoView backend would simply not implement the synchronous API as it should never be called.

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1596663 - Add searchLoginsAsync nsILoginManagerStorage method. r=sfoster

We need to switch the APIs used for capture/fill (not management) to be async to support async queries a GeckoView login storage provider.

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1596663 - Use searchLoginsAsync in _searchAndDedupeLogins. r=sfoster

Update callers to await on the result.

Depends on D53149

Comment 3

[Matthew N. [:MattN]]

Attachment: Bug 1596663 - Use searchLoginsAsync for login searches by guid. r=sfoster

Depends on D53150

Comment 4

[Matthew N. [:MattN]]

Attachment: Bug 1596663 - Convert LoginManagerStorage_json to a JS class. r=sfoster

Comment 5

[Matthew N. [:MattN]]

Attachment: Bug 1596663 - Use `Promise` IDL return values instead of jsval in passwordmgr. r=sfoster

The Promise type wasn't available to XPIDL when these were added.

Depends on D54138

Comment 6

[Matthew N. [:MattN]]

Attachment: Bug 1596663 - Remove more passwordmgr references to `hostname`. r=sfoster

Depends on D54779

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3d9094fbb28
Add searchLoginsAsync nsILoginManagerStorage method. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/c11b9109664e
Use searchLoginsAsync in _searchAndDedupeLogins. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/8d7dab582ae4
Use searchLoginsAsync for login searches by guid. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/7aef5a5252b1
Convert LoginManagerStorage_json to a JS class. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/acb67bbe1545
Use `Promise` IDL return values instead of jsval in passwordmgr. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/8264925bfb7d
Remove more passwordmgr references to `hostname`. r=sfoster

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/a3d9094fbb28
https://hg.mozilla.org/mozilla-central/rev/c11b9109664e
https://hg.mozilla.org/mozilla-central/rev/8d7dab582ae4
https://hg.mozilla.org/mozilla-central/rev/7aef5a5252b1
https://hg.mozilla.org/mozilla-central/rev/acb67bbe1545
https://hg.mozilla.org/mozilla-central/rev/8264925bfb7d