1596673 - Some WhatsNew links don't actually go to the defined anchors, and some could go to hacks instead

Status: VERIFIED FIXED

(DevTools Graveyard :: What's New, defect)

Comment 1

[Patrick Brosset <:pbro>]

Attachment: Bug 1596673 - Fixing the position of anchors in a few urls, and replacing one with hacks.m.o

Some anchors were appearing before the url params part, which prevented them from
actually being recognized and the page being scrolled to the right position.

Also the inactive CSS link went to mdn, but we don't have docs there yet for it. So I
changed it to go to hacks.m.o instead.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5814678b2659
Fixing the position of anchors in a few urls, and replacing one with hacks.m.o r=jlast

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/5814678b2659

Comment 4

[:Harald Kirschner :digitarald]

Comment on attachment 9108951 [details]
Bug 1596673 - Fixing the position of anchors in a few urls, and replacing one with hacks.m.o

Beta/Release Uplift Approval Request

• User impact if declined: Broken direct links to specific in-page sections that describe features in the the What's New panel
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Click through the features in the DevTools What's New panel.
  Links should open with utm_ query parameters and sometimes with a hash appended.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just changed links.
• String changes made/needed:

Comment 5

[Pascal Chevrel:pascalc]

Comment on attachment 9108951 [details]
Bug 1596673 - Fixing the position of anchors in a few urls, and replacing one with hacks.m.o

Fix bugs in new what's new panel uplifted to beta, uplift approved for 71 beta 11, thanks.

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/43c1897425fd

Comment 7

[Cristian Fogel [:cfogel]]

Verified with 71.0b11 and 72.0a1 (2019-11-17).
Links and anchors are opening the expected links/positions in page.