Closed Bug 1596673 Opened 3 months ago Closed 3 months ago

Some WhatsNew links don't actually go to the defined anchors, and some could go to hacks instead

Categories

(DevTools :: What's New, defect)

All
Unspecified
defect
Not set

Tracking

(firefox71 verified, firefox72 verified)

VERIFIED FIXED
Firefox 72
Tracking Status
firefox71 --- verified
firefox72 --- verified

People

(Reporter: pbro, Assigned: pbro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.

Some anchors were appearing before the url params part, which prevented them from
actually being recognized and the page being scrolled to the right position.

Also the inactive CSS link went to mdn, but we don't have docs there yet for it. So I
changed it to go to hacks.m.o instead.

Component: General → What's New
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5814678b2659
Fixing the position of anchors in a few urls, and replacing one with hacks.m.o r=jlast
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

Comment on attachment 9108951 [details]
Bug 1596673 - Fixing the position of anchors in a few urls, and replacing one with hacks.m.o

Beta/Release Uplift Approval Request

  • User impact if declined: Broken direct links to specific in-page sections that describe features in the the What's New panel
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Click through the features in the DevTools What's New panel.
    Links should open with utm_ query parameters and sometimes with a hash appended.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just changed links.
  • String changes made/needed:
Attachment #9108951 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Comment on attachment 9108951 [details]
Bug 1596673 - Fixing the position of anchors in a few urls, and replacing one with hacks.m.o

Fix bugs in new what's new panel uplifted to beta, uplift approved for 71 beta 11, thanks.

Attachment #9108951 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified with 71.0b11 and 72.0a1 (2019-11-17).
Links and anchors are opening the expected links/positions in page.

Status: RESOLVED → VERIFIED
Hardware: Unspecified → All
You need to log in before you can comment on or make changes to this bug.