1596737 - Additional minidumps are not deleted after submitting a hang from the infobar

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect, P2)

Description

[Gabriele Svelto [:gsvelto] (PTO)]

A hang will usually have multiple minidumps and an associated extra file, e.g.:

• 3664de53-454d-6e0d-9f83-1c23be054514.extra
• 3664de53-454d-6e0d-9f83-1c23be054514.dmp
• 3664de53-454d-6e0d-9f83-1c23be054514-browser.dmp

When submitting one from the infobar one should end up with an empty .ignore file, e.g.:

• 3664de53-454d-6e0d-9f83-1c23be054514.dmp.ignore

Unfortunately it seems that this method is missing the additional minidumps, so one ends up like this instead:

• 3664de53-454d-6e0d-9f83-1c23be054514.dmp.ignore
• 3664de53-454d-6e0d-9f83-1c23be054514-browser.dmp

Note that because we submit orphaned minidumps (i.e. minidumps w/o an associated .extra file) this could skew our crash stats.

Comment 1

[Gabriele Svelto [:gsvelto] (PTO)]

Ouch, this is giving me headaches. After looking at the code I noticed multiple overlapping issues that all boil down to a single thing: we don't have an object that represents a crash and all the code that deals with the various files will often look only at a subset of them. Additionally it seems like we're not deleting outdated crashes anymore - and we don't send them either which might cause problems to users in the long run.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:gsvelto, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Gabriele Svelto [:gsvelto] (PTO)]

This should be done soon enough.

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: Bug 1596737 - Properly remove additional minidumps when submitting a crash report r=mconley

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc9c4b5cb5ba
Properly remove additional minidumps when submitting a crash report r=mconley

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/bc9c4b5cb5ba