Closed Bug 1596751 Opened 3 months ago Closed 8 days ago

Re-enable browser_tab_drag_drop_perwindow.js

Categories

(Firefox :: Tabbed Browser, task, P2)

task

Tracking

()

RESOLVED FIXED
Firefox 75
Fission Milestone M4.1
Tracking Status
firefox75 --- fixed

People

(Reporter: enndeakin, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

There is code at:

https://searchfox.org/mozilla-central/rev/cac340f10816707e91c46db6d285f80259420f07/toolkit/components/startup/nsAppStartup.cpp#599

that explicitly fails when a window is opened with fission enabled and the remote flag is false. This causes the test browser_tab_drag_drop_perwindow.js to fail because it doesn't create the window.

Not sure what the reason for that is but perhaps 'remote: false' should just imply that fission is false as well.

However, I also tried changing the window flags at:

https://searchfox.org/mozilla-central/rev/cac340f10816707e91c46db6d285f80259420f07/browser/base/content/test/general/browser_tab_drag_drop_perwindow.js#96

to { remote: false, fission: false )

That also fails as it creates a window with gFissionBrowser set to false but gMultiProcessBrowser set to true and the tab dropping code thinks this is a remote browser. I wouldn't expect gMultiProcessBrowser to be true here considering those window open flags.

Fission Milestone: --- → M4.1
Component: General → Tabbed Browser
Priority: -- → P3
Priority: P3 → --
Priority: -- → P3
Priority: P3 → P2

Dão, this bug is a blocker for Fission's current milestone (M4.1 aka "fix all the mochitests"), but it's currently unassigned. The Fission team is hoping teams will fix their mochitests for Fission before the end of Q1 (75 or 76 Nightly).

Will your team be able to prioritize this bug for Q1? If you don't think this mochitest failure should block shipping Fission, just let me know

If you have questions for Fission engineers, you can reach them in the #fission channel on Slack or Riot.

Flags: needinfo?(dao+bmo)

(In reply to Neil Deakin from comment #0)

However, I also tried changing the window flags at:

https://searchfox.org/mozilla-central/rev/cac340f10816707e91c46db6d285f80259420f07/browser/base/content/test/general/browser_tab_drag_drop_perwindow.js#96

to { remote: false, fission: false )

That also fails as it creates a window with gFissionBrowser set to false but gMultiProcessBrowser set to true and the tab dropping code thinks this is a remote browser. I wouldn't expect gMultiProcessBrowser to be true here considering those window open flags.

It looks like this isn't an issue anymore: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce58acdb8fb2a9bf6aa30102bf4f3caa650a9636

Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2c3f94c7e66
Make browser_tab_drag_drop_perwindow.js work with fission. r=NeilDeakin
Status: ASSIGNED → RESOLVED
Closed: 8 days ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
You need to log in before you can comment on or make changes to this bug.