1596766 - Engine selector should return a single locale for each engine

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

Currently the Search Engine Selector looks like it is returning multiple locales per engine. I think generally it isn't, and it is confusing that it can, because effectively they're two different engines.

I think we should change it so that the selector only returns one locale per engine, and this would simplify the understanding of the code.

Comment 1

[Mark Banner (:standard8)]

Note: toolkit/components/search/tests/xpcshell/test_webextensions_install.js already covers the multi-locale functionality, this is just simplifying how the backend handles it.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1596766 - Change the Search Engine Selector to return a string rather than array of locales. r?mikedeboer

The configuration may specify multiple locales for a search engine. The search engine selector already splits these out into different engine objects, but keeps the locale field as an array. This patch changes the 'locales' array into a 'locale' string and applies appropriate simplifications to the search service.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a45094b7aa1
Change the Search Engine Selector to return a string rather than array of locales. r=mikedeboer

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1596766 - Followup, fix a missed instance in the SearchService of switching an array to a string for the locales change. r?daleharvey

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1a45094b7aa1

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d61646919205
Followup, fix a missed instance in the SearchService of switching an array to a string for the locales change. r=daleharvey

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/d61646919205