1596768 - Remove more GetBindingParent usage.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P3)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1596768 - Remove GetBindingParent usage in RangeUtils. r=smaug

Shadow DOM is handled above.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1596768 - Remove GetBindingParent usage in nsIContent::FindFirstNonChromeOnlyAccessContent. r=smaug

This one is a bit subtle, but not too much.

Depends on D53193

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1596768 - Remove GetBindingParent usage in GetRootForContentSubtree. r=smaug

Shadow DOM is handled above.

And do some minor drive-by cleanups. Unclear why we have both this and the
RangeUtils version.

Depends on D53194

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1596768 - Remove GetBindingParent usage in nsContentUtils::IsInSameAnonymousTree. r=smaug

Check Shadow DOM and NAC separately.

Depends on D53195

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1596768 - Remove GetBindingParent() usage in GetEventTargetParent. r=smaug

Depends on D53196

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1596768 - Remove GetBindingParent usage in nsRange assertions. r=smaug

They want to check that the root is correct, do so explicitly.

Depends on D53197

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1596768 - Remove GetBindingParent usage in editor. r=smaug

Depends on D53198

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1596768 - Remove GetBindingParentUsage in xpath. r=smaug

Wants to check that the change happens in the same anon tree, use the right
function for that.

Depends on D53199

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1596768 - Remove GetBindingParent usage in EventStateManager. r=smaug

This one I'm not 100% sure about whether we want to keep special-casing shadow
DOM.

Seems we may want to, but on the other hand this looks like a hack (as it only
looks at the closest shadow host, not the whole chain, and it is green on try).

Depends on D53200

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1596768 - Remove GetBindingParent() in HTMLFormControlAccessible. r=MarcoZ

This code doesn't want to deal with Shadow DOM but with <input type=number> and
such native-anonymous inputs. So do that explicitly.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1596768 - Keep Document::GetBindingParent doing the same without nsIContent::GetBindingParent(). r=smaug

See the follow-up bug for the proposal to get rid of it.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1596768 - Remove GetBindingParent usage in layout. r=smaug

We only use it to escape out of NAC trees for ::selection pseudo-element.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc106b1c9d29
Remove GetBindingParent usage in RangeUtils. r=smaug

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ece9bc4cec2
Remove GetBindingParent usage in nsRange assertions. r=smaug

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85ae973aca6e
Remove GetBindingParent usage in layout. r=smaug

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b2de590fde9
Remove GetBindingParent usage in nsIContent::FindFirstNonChromeOnlyAccessContent. r=smaug

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbc1778c0ebd
Keep Document::GetBindingParent doing the same without nsIContent::GetBindingParent(). r=smaug

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce407536b1dc
Remove GetBindingParent usage in GetRootForContentSubtree. r=smaug

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c80cebff64aa
Remove GetBindingParent() usage in GetEventTargetParent. r=smaug

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db1a18b908bf
Remove GetBindingParent usage in nsContentUtils::IsInSameAnonymousTree. r=smaug

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afb9438378f0
Remove GetBindingParent usage in editor. r=smaug

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cd52ac39a81
Remove GetBindingParentUsage in xpath. r=smaug

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c323325a513
Remove GetBindingParent usage in EventStateManager. r=smaug

Comment 24

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/bc106b1c9d29
https://hg.mozilla.org/mozilla-central/rev/0ece9bc4cec2
https://hg.mozilla.org/mozilla-central/rev/85ae973aca6e
https://hg.mozilla.org/mozilla-central/rev/0b2de590fde9
https://hg.mozilla.org/mozilla-central/rev/dbc1778c0ebd
https://hg.mozilla.org/mozilla-central/rev/ce407536b1dc
https://hg.mozilla.org/mozilla-central/rev/c80cebff64aa
https://hg.mozilla.org/mozilla-central/rev/db1a18b908bf
https://hg.mozilla.org/mozilla-central/rev/afb9438378f0
https://hg.mozilla.org/mozilla-central/rev/4cd52ac39a81
https://hg.mozilla.org/mozilla-central/rev/9c323325a513

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74841f58fb9f
Remove GetBindingParent() in HTMLFormControlAccessible. r=surkov

Comment 26

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/74841f58fb9f