Closed Bug 1596786 Opened 5 years ago Closed 4 years ago

Arrow keys support for reftest-analyzer

Categories

(Core :: Graphics, enhancement, P3)

72 Branch
Desktop
All
enhancement

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: bpeers, Assigned: bpeers)

Details

Attachments

(1 file, 2 obsolete files)

Hunting a bad pixel with a trackpad on a highDPI laptop can be frustrating; add arrowkey support so the highlighted pixel can be adjusted using arrow keys.

Assignee: nobody → bpeers
Priority: -- → P3

(also add vim-style HJKL in case the frame has scrollbars)

Feedback from https://phabricator.services.mozilla.com/D53220

  • removed vim-style keybinding
  • removed unnecessary || window.event
    = fixed coding guideline violations
  • explicit early out for NaN coordinates (vs. relying on image bounds)
Attachment #9111293 - Attachment is obsolete: true
Attachment #9109068 - Attachment is obsolete: true
Attachment #9109068 - Attachment is obsolete: false
Pushed by bpeers@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/80127dcd9ada
Arrow keys support for reftest-analyzer r=dbaron
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Attachment #9112071 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: