1596834 - Make extensions/permissions/test/browser_permmgr_sync.js use forceNewProcess

Status: RESOLVED FIXED

(Core :: Permission Manager, task, P2)

Description

[Andrew McCreight [:mccr8]]

browser_permmgr_sync.js uses the pref dom.ipc.keepProcessesAlive.web to ensure that it gets a fresh process during testing, which is not going to work with Fission. A comment in that test says "Bug 1345990 tracks implementing a better tool for ensuring this" and fortunately that bug was fixed 2 years ago. It looks like the fix is adding a new option forceNewProcess: true to BTU.withNewTab.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1596834 - Use forceNewProcess in browser_permmgr_sync.js.

Also fix a few typos in comments.

Comment 2

[Andrew McCreight [:mccr8]]

I was hoping this might fix the test with Fission, but it doesn't have any apparent impact on the results when Fission is enabled. But it is probably still a prerequisite.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4177c6123ddb
Use forceNewProcess in browser_permmgr_sync.js. r=mconley

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4177c6123ddb