Closed Bug 1596834 Opened 11 months ago Closed 11 months ago

Make extensions/permissions/test/browser_permmgr_sync.js use forceNewProcess

Categories

(Core :: Permission Manager, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla72
Fission Milestone M4.1
Tracking Status
firefox72 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

browser_permmgr_sync.js uses the pref dom.ipc.keepProcessesAlive.web to ensure that it gets a fresh process during testing, which is not going to work with Fission. A comment in that test says "Bug 1345990 tracks implementing a better tool for ensuring this" and fortunately that bug was fixed 2 years ago. It looks like the fix is adding a new option forceNewProcess: true to BTU.withNewTab.

Also fix a few typos in comments.

I was hoping this might fix the test with Fission, but it doesn't have any apparent impact on the results when Fission is enabled. But it is probably still a prerequisite.

Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4177c6123ddb
Use forceNewProcess in browser_permmgr_sync.js. r=mconley
Blocks: 1596855
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Fission Milestone: --- → M4.1
You need to log in before you can comment on or make changes to this bug.