1596843 - Remove some unused nsIPermissionManager APIs

Status: RESOLVED FIXED

(Core :: Permission Manager, defect)

Comment 1

[(no longer active)]

Attachment: Bug 1596843 - Part 1: Remove the unused nsIPermissionManager.testPermissionFromWindow() method;

Comment 2

[(no longer active)]

Attachment: Bug 1596843 - Part 2: Stop exposing nsIPermissionManager.removePermissionsWithAttributes();

Comment 3

[(no longer active)]

Attachment: Bug 1596843 - Part 3: Remove the unused nsIPermissionManager.updateExpireTime() method;

Comment 4

[(no longer active)]

Attachment: Bug 1596843 - Part 4: Remove some native only methods from nsIPermissionManager;

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b10aec041377
Part 1: Remove the unused nsIPermissionManager.testPermissionFromWindow() method; r=baku
https://hg.mozilla.org/integration/autoland/rev/8b2220bc47af
Part 2: Stop exposing nsIPermissionManager.removePermissionsWithAttributes(); r=baku
https://hg.mozilla.org/integration/autoland/rev/a9827fae8655
Part 3: Remove the unused nsIPermissionManager.updateExpireTime() method; r=baku
https://hg.mozilla.org/integration/autoland/rev/69ee727d5b45
Part 4: Remove some native only methods from nsIPermissionManager; r=baku

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de185bb7bdd5
Backed out 4 changesets for XPCShellTestsTests build bustage ona CLOSED TREE.

Comment 7

[Raul Gurzau (:RaulG)]

: Ehsan Hi, tried to land these changes to test them but got some failures and a backout was needed.

These are the failures:

• XPCShellTestsTests::testChild TEST-UNEXPECTED-FAIL: TH link | Log link

• Assertion failure at nsPermissionManager.cpp: Th link | Log link

• application crashed [@ nsPermissionManager::SetPermissionsWithKey(nsTSubstring<char> const&, nsTArray<IPC::Permission>&)] TH link | Log link

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88e8383dc3e4
Part 1: Remove the unused nsIPermissionManager.testPermissionFromWindow() method; r=baku
https://hg.mozilla.org/integration/autoland/rev/691397c2fde6
Part 2: Stop exposing nsIPermissionManager.removePermissionsWithAttributes(); r=baku
https://hg.mozilla.org/integration/autoland/rev/b9061f93d045
Part 3: Remove the unused nsIPermissionManager.updateExpireTime() method; r=baku
https://hg.mozilla.org/integration/autoland/rev/48577632f4b3
Part 4: Remove some native only methods from nsIPermissionManager; r=baku

Comment 9

[Noemi Erli[:noemi_erli]]

Backed out 4 changesets (Bug 1596843) for causing nsPermissionManager related failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=276660753&resultStatus=testfailed%2Cbusted%2Cexception&revision=48577632f4b3af48fc3a29b85d395d5e50ce9357

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276660753&repo=autoland&lineNumber=1331
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276660752&repo=autoland&lineNumber=1479
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276660981&repo=autoland&lineNumber=615
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276662253&repo=autoland&lineNumber=3214
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276660937&repo=autoland&lineNumber=2066

Backout: https://hg.mozilla.org/integration/autoland/rev/7553b88698cb6552427de9638bbb63c5776495a5

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83096c9e152d
Part 1: Remove the unused nsIPermissionManager.testPermissionFromWindow() method; r=baku
https://hg.mozilla.org/integration/autoland/rev/70e1692d29f5
Part 2: Stop exposing nsIPermissionManager.removePermissionsWithAttributes(); r=baku
https://hg.mozilla.org/integration/autoland/rev/21bfefb23045
Part 3: Remove the unused nsIPermissionManager.updateExpireTime() method; r=baku
https://hg.mozilla.org/integration/autoland/rev/03b7360a15dd
Part 4: Remove some native only methods from nsIPermissionManager; r=baku

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/83096c9e152d
https://hg.mozilla.org/mozilla-central/rev/70e1692d29f5
https://hg.mozilla.org/mozilla-central/rev/21bfefb23045
https://hg.mozilla.org/mozilla-central/rev/03b7360a15dd