Closed Bug 1596872 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 20277 - [offscreen-canvas] Correctly report result of asynchronous operations

Categories

(Core :: Graphics: Canvas2D, task, P4)

Product:
Core
Component:
Graphics: Canvas2D
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20277 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20277
Details from upstream follow.

Mike Pennisi <mike@mikepennisi.com> wrote:

[offscreen-canvas] Correctly report result of asynchronous operations

This resolves gh-20180.

In master today, the test results are misrepresenting implementation status. Many failing tests are incorrectly reporting as having passed. Some of them also report an error in the testing harness (which ought to hint that something is going wrong), but many claim to be OK.

This patch makes the tests accurately report PASS or FAIL and removes the test harness errors.

To demonstrate this, I scheduled trials for the patch in Chrome and Firefox. We can use https://wpt.fyi to compare the results reported for each browser with and without this patch (hint: there is a toggle button in the UI just below the icon labeled "diff" that helps you to view only differences):

Firefox does not implement OffscreenCanvas, so (as expected) this patch had no effect on Firefox's results. There is one discrepancy, but that's due to an unrelated crash--something that happens from time to time in the test environment.

Chrome's results are much improved. Individual test results changed in one of two ways, as reported in the wpt.fyi UI:

  • +1 / -1 / 0 - this means there is one more passing "statistic" and one more failing "statistic." The statistics combine subtest results and harness status, so this specifically means: the harness status changed from ERROR to OK and the subtest result changed from PASS to FAIL.
  • 0 / -1 / 0 - here, the harness status was unchanged, and the subtest result changed from PASS to FAIL.

I've split this into two commits: one for the template and source file changes, and one for the corresponding changes to the generated test material. I don't know how you folks prefer to review or merge changes like this, though, and I'm happy to reconfigure as you please.

Component: web-platform-tests → Canvas: 2D
Product: Testing → Core
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7f5ad7bc0f3f [wpt PR 20277] - [offscreen-canvas] Correctly report result of asynchronous operations, a=testonly

https://hg.mozilla.org/mozilla-central/rev/7f5ad7bc0f3f

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.