Closed
Bug 1596950
Opened 5 years ago
Closed 5 years ago
C code compiled by Rust should use asan/fuzzing compiler flags when possible.
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox72 fixed)
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: truber, Assigned: truber)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We pass cargo only base compiler flags because it can't use different flags for host and target when they are the same machine (https://github.com/rust-lang/cargo/issues/5755).
We currently do this for MOZ_ASAN, MOZ_TSAN, MOZ_UBSAN, CODE_COVERAGE_GCC, and FUZZING_INTERFACES.
This isn't a problem when cross-compiling asan, and shouldn't be a problem at all for fuzzing interfaces.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Pushed by dvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/94c9b646c48d Pass compiler flags to cargo for cross-compiled ASAN and fuzzing builds. r=froydnj
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•