1596950 - C code compiled by Rust should use asan/fuzzing compiler flags when possible.

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Jesse Schwartzentruber (:truber)]

We pass cargo only base compiler flags because it can't use different flags for host and target when they are the same machine (https://github.com/rust-lang/cargo/issues/5755).

We currently do this for MOZ_ASAN, MOZ_TSAN, MOZ_UBSAN, CODE_COVERAGE_GCC, and FUZZING_INTERFACES.

This isn't a problem when cross-compiling asan, and shouldn't be a problem at all for fuzzing interfaces.

Comment 1

[Jesse Schwartzentruber (:truber)]

Attachment: Bug 1596950 - Pass compiler flags to cargo for cross-compiled ASAN and fuzzing builds.

Comment 2

[Jesse Schwartzentruber (:truber)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=75c62cd16e34cd868409635647469e331500229d

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94c9b646c48d
Pass compiler flags to cargo for cross-compiled ASAN and fuzzing builds. r=froydnj

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/94c9b646c48d